Skip to content

Change SolutionState._lazyFilePathToRelatedDocumentIds to a ConcurrentDictionary #77959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025
Merged

Change SolutionState._lazyFilePathToRelatedDocumentIds to a ConcurrentDictionary #77959

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions src/Workspaces/Core/Portable/Workspace/Solution/SolutionState.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// See the LICENSE file in the project root for more information.

using System;
using System.Collections.Concurrent;
using System.Collections.Generic;
using System.Collections.Immutable;
using System.Diagnostics;
Expand Down Expand Up @@ -58,7 +59,8 @@ internal sealed partial class SolutionState
// holds on data calculated based on the AnalyzerReferences list
private readonly Lazy<HostDiagnosticAnalyzers> _lazyAnalyzers;

private ImmutableDictionary<string, ImmutableArray<DocumentId>> _lazyFilePathToRelatedDocumentIds = ImmutableDictionary<string, ImmutableArray<DocumentId>>.Empty.WithComparers(FilePathComparer);
// Mapping from file path to the set of documents that are related to it.
private readonly ConcurrentDictionary<string, ImmutableArray<DocumentId>> _lazyFilePathToRelatedDocumentIds = new ConcurrentDictionary<string, ImmutableArray<DocumentId>>(FilePathComparer);

private SolutionState(
string? workspaceKind,
Expand Down Expand Up @@ -1169,16 +1171,12 @@ public ImmutableArray<DocumentId> GetDocumentIdsWithFilePath(string? filePath)
if (string.IsNullOrEmpty(filePath))
return [];

return ImmutableInterlocked.GetOrAdd(
ref _lazyFilePathToRelatedDocumentIds,
filePath,
static (filePath, @this) => ComputeDocumentIdsWithFilePath(@this, filePath),
this);
return _lazyFilePathToRelatedDocumentIds.GetOrAdd(filePath, ComputeDocumentIdsWithFilePath, this);

static ImmutableArray<DocumentId> ComputeDocumentIdsWithFilePath(SolutionState @this, string filePath)
static ImmutableArray<DocumentId> ComputeDocumentIdsWithFilePath(string filePath, SolutionState @this)
{
using var result = TemporaryArray<DocumentId>.Empty;
foreach (var (projectId, projectState) in @this.ProjectStates)
foreach (var (_, projectState) in @this.ProjectStates)
projectState.AddDocumentIdsWithFilePath(ref result.AsRef(), filePath);

return result.ToImmutableAndClear();
Expand Down
Loading