Disable TransitiveVersioningPinning for RoslynAnalyzers.

[JoeRobich]

Transitive pinning is breaking source-build in SDK insertions. See dotnet/sdk#48088

Changes to MissingRulesDocumentation are automated.

[JoeRobich]

/backport to main

[github-actions]

Started backporting to main: https://github.com/dotnet/roslyn/actions/runs/14322057607

[ViktorHofer]

@JoeRobich this change is insufficient. Directory.Packages.props gets imported after Directory.Build.props and therefore the property gets reassigned back to true. You want to move this into the Directory.Build.targets file.

FWIW you can also test this by building the VMR locally or in a Codespace with the changes from this PR: dotnet/sdk#48088

[Forgind]

Should Directory.Packages.props have a Condition="'$(CentralPackageTransitivePinningEnabled)' == ''" check?

[ViktorHofer]

That's another option. There are so many ways with msbuild :)

[JoeRobich]

by building the VMR locally or in a Codespace with the changes from this PR: dotnet/sdk#48088

@ViktorHofer Is there a doc I can reference?

[JoeRobich]

Also, would have been nice to catch this issue during Roslyn's source build leg instead of in the SDK.

[ViktorHofer]

Also, would have been nice to catch this issue during Roslyn's source build leg instead of in the SDK.

So, roslyn's current source-build job is only an approximation on how the product build will perform. That job will actually go away as it has proven to be not that helpful: dotnet/source-build#5020. Instead, we will add the option to perform a full VMR product build with the repo local changes: dotnet/arcade-services#4539

That validation leg will highlight such issues. The repo owners then decide if they want that pipeline run as part of every PR or as an optional comment-trigger pipeline. cc @jaredpar @MichaelSimons

@ViktorHofer Is there a doc I can reference?

For the codespace and how to sync PR changes into the VMR: https://github.com/dotnet/sdk/blob/main/.devcontainer/vmr/README.md

General instructions on how to build the VMR can be found here: https://github.com/dotnet/dotnet?tab=readme-ov-file#dev-instructions