[release/dev17.14] Fix crash in backing field nullability cycle scenario #78055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Compilers
untriaged
jaredpar
approved these changes
Apr 8, 2025
jaredpar
added
Feature - Field Keyword
and removed
untriaged
This was referenced Apr 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://dev.azure.com/devdiv/DevDiv/_workitems/edit/2441901
Backport of #77993 to release/dev17.14
/cc @RikkiGibson
Customer Impact
Without this change, a user in the default configuration effectively can't use the
fieldkeyword in structs.Regression
Regression introduced in #77127.
Testing
Added a bunch of new unit tests to try and find more cycles in nullable backing field inference.
Risk
Low. We adjusted the code so that when the problematic condition is encountered in release builds, we short circuit the inference, choose a "reasonable" value, for the nullability and proceed, instead of crashing.