Simplify internal analyzer api #78070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Analyzers
untriaged
ToddGrun
reviewed
Apr 8, 2025
| public override async Task<ImmutableArray<Diagnostic>> AnalyzeSyntaxAsync(TextDocument textDocument, SyntaxTree? tree, CancellationToken cancellationToken) | ||
| => XamlProjectService.AnalyzerService is null || textDocument is not Document document | ||
| ? [] | ||
| : await XamlProjectService.AnalyzerService.AnalyzeSyntaxAsync(document, cancellationToken).ConfigureAwait(false); |
Contributor
Member
Author
There was a problem hiding this comment.
yes. because on different paths we return different values.
Contributor
There was a problem hiding this comment.
Making sure we're thinking of the same change:
public override Task<ImmutableArray<Diagnostic>> AnalyzeSyntaxAsync(TextDocument textDocument, SyntaxTree? tree, CancellationToken cancellationToken)
=> XamlProjectService.AnalyzerService is null || textDocument is not Document document
? SpecializedTasks.EmptyImmutableArray<Diagnostic>()
: XamlProjectService.AnalyzerService.AnalyzeSyntaxAsync(document, cancellationToken);
Contributor
There was a problem hiding this comment.
@CyrusNajmabadi -- not a deal breaker, just curious why the suggested code wouldn't work
Member
Author
There was a problem hiding this comment.
That would work... Or just the code already there :-)
Member
Author
There was a problem hiding this comment.
I'm not huge on avoiding async/await personally.
ToddGrun
reviewed
Apr 8, 2025
| => SpecializedTasks.EmptyImmutableArray<Diagnostic>(); | ||
|
|
||
| public override Task<ImmutableArray<Diagnostic>> AnalyzeSyntaxAsync(Document document, CancellationToken cancellationToken) | ||
| public override Task<ImmutableArray<Diagnostic>> AnalyzeSyntaxAsync(TextDocument document, SyntaxTree? tree, CancellationToken cancellationToken) |
Contributor
Member
Author
There was a problem hiding this comment.
No. This is just text code
Member
Author
|
@ToddGrun ptal. |
ToddGrun
approved these changes
Apr 9, 2025
This was referenced Apr 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.