Support consumption of instance compound assignment operators #78087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
untriaged
Contributor
Author
Contributor
Author
333fred
approved these changes
Apr 10, 2025
| return null; | ||
| } | ||
|
|
||
| Debug.Assert(!methods.IsEmpty); |
Member
There was a problem hiding this comment.
Nit: is this assert actually helping anything? We just checked that.
Contributor
Author
|
@cston, @dotnet/roslyn-compiler For the second review |
cston
reviewed
Apr 11, 2025
| if (checkedName is not null) | ||
| { | ||
| this.LookupMembersWithFallback(lookupResult, lookupInType, name: checkedName, arity: 0, ref useSiteInfo, basesBeingResolved: null, options: LookupOptions.MustBeInstance | LookupOptions.MustBeOperator); | ||
| ArrayBuilder<MethodSymbol>? LookupUserDefinedInstanceOperators(TypeSymbol lookupInType, string? checkedName, string ordinaryName, int parameterCount, ref CompoundUseSiteInfo<AssemblySymbol> useSiteInfo) |
Contributor
Author
There was a problem hiding this comment.
I will add the modifier in the next PR
cston
approved these changes
Apr 11, 2025
AlekseyTs
merged commit 2b1abe9
into
dotnet:features/UserDefinedCompoundAssignment
24 checks passed
This was referenced May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.