Project system cleanups #78104
Merged
Project system cleanups #78104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CPS appears to have moved to the new one several years ago, so we can delete this now.
ghost
added
Area-IDE
untriaged
CyrusNajmabadi
approved these changes
Apr 11, 2025
I'm a bit suspicious that re-enabling that exception might be unsafe, so let's be a bit friendlier.
jasonmalinowski
force-pushed
the
project-system-cleanups
branch
from
2cb96ba to
a78ef3e
Compare
jasonmalinowski
commented
Apr 11, 2025
| var joinedValues = string.Join(";", values); | ||
| throw new InvalidProjectDataException(itemName, joinedValues, $"Item group '{itemName}' is required to specify a single value: '{joinedValues}'."); | ||
| } | ||
| else if (values.Length == 0) |
Member
Author
There was a problem hiding this comment.
It seems a bit suspicious to me that if we didn't get any back we'd throw an exception since that could be an error case...so going to change the logic a bit.
This was referenced Apr 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stuff we can delete I noticed while looking at a potential performance improvement.