Skip to content

Fix issue #70183: adjust the plural for expression collection #78110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 15, 2025
Merged

Fix issue #70183: adjust the plural for expression collection #78110

merged 3 commits into from
Apr 15, 2025

Conversation

@kirisky
Copy link
Contributor

@kirisky kirisky commented Apr 11, 2025

Fix issue #70183

@kirisky kirisky requested a review from a team as a code owner April 11, 2025 10:00
@ghost ghost added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 11, 2025
@dotnet-policy-service dotnet-policy-service bot added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Apr 11, 2025
@kirisky kirisky mentioned this pull request Apr 11, 2025
Closed
@jaredpar jaredpar removed the untriaged Issues and PRs which have not yet been triaged by a lead label Apr 12, 2025
kirisky
kirisky commented Apr 13, 2025
View reviewed changes
AlekseyTs
AlekseyTs reviewed Apr 14, 2025
View reviewed changes
@AlekseyTs
Copy link
Contributor

AlekseyTs commented Apr 14, 2025

Done with review pass (commit 2)

AlekseyTs
AlekseyTs approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 3)

@AlekseyTs AlekseyTs requested review from a team and cston April 14, 2025 14:58
@AlekseyTs
Copy link
Contributor

AlekseyTs commented Apr 14, 2025

@dotnet/roslyn-compiler For the second review

@jjonescz jjonescz merged commit 7ebe9bf into dotnet:main Apr 15, 2025
24 checks passed
@jjonescz
Copy link
Member

jjonescz commented Apr 15, 2025

Thanks for the contribution @kirisky

@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Apr 15, 2025
@kirisky kirisky deleted the 70183-adjust-the-plural-for-collection-expressions branch April 15, 2025 08:34
This was referenced Apr 19, 2025
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request May 31, 2025
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 18.0 P1 Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjonescz jjonescz jjonescz approved these changes

@AlekseyTs AlekseyTs AlekseyTs approved these changes

@cston cston Awaiting requested review from cston

Assignees

No one assigned

Labels

Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Milestone

18.0 P1

Development

Successfully merging this pull request may close these issues.

5 participants

@kirisky @AlekseyTs @jjonescz @jaredpar @RikkiGibson