Add generic log message to avoid lambda allocations. #78128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
Member
Author
|
@ToddGrun @JoeRobich ptal. |
Member
Author
|
@JoeRobich @dibarbet @ToddGrun @tmat ptal. |
ToddGrun
reviewed
Apr 13, 2025
| if (_lazyMap == null) | ||
| { | ||
| _lazyMap = SharedPools.Default<Dictionary<string, object?>>().AllocateAndClear(); | ||
| _propertySetter.Invoke(_lazyMap, _args); |
Contributor
ToddGrun
reviewed
Apr 13, 2025
| public static GenericKeyValueLogMessage<TArgs> Create( | ||
| Action<Dictionary<string, object?>, TArgs> propertySetter, TArgs args, LogLevel logLevel) | ||
| { | ||
| var logMessage = s_pool.Allocate(); |
Contributor
ToddGrun
reviewed
Apr 13, 2025
| LogLevel = logLevel; | ||
| } | ||
|
|
||
| public static new SimpleKeyValueLogMessage Create(Action<Dictionary<string, object?>> propertySetter, LogLevel logLevel = LogLevel.Information) |
Contributor
ToddGrun
reviewed
Apr 13, 2025
| { | ||
| private static readonly ObjectPool<SimpleKeyValueLogMessage> s_pool = new(() => new()); | ||
|
|
||
| private Action<Dictionary<string, object?>>? _propertySetter; |
Contributor
Contributor
|
Love it! I notice these allocations when I'm looking at the code, but it never seems to pop in a profile. Death by a thousand papercuts, I suppose. In reply to: 2798487395 |
Member
Author
|
@ToddGrun ok with signing off? I can handle the mop up in a new pr. |
This was referenced Apr 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.