Skip to content

Fix quick info for pp symbols #78173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 18, 2025
Merged

Fix quick info for pp symbols #78173

merged 2 commits into from
Apr 18, 2025

Conversation

@Rekkonnect
Copy link
Contributor

@Rekkonnect Rekkonnect commented Apr 16, 2025 •
edited by CyrusNajmabadi
Loading

@Rekkonnect
Fix quick info for pp symbols
bbc5b45 
It would previously cause an exception during accessibility check
@Rekkonnect Rekkonnect requested a review from a team as a code owner April 16, 2025 18:35
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 16, 2025
@dotnet-policy-service dotnet-policy-service bot added Community The pull request was submitted by a contributor who is not a Microsoft employee. VSCode labels Apr 16, 2025
@CyrusNajmabadi
Copy link
Member

CyrusNajmabadi commented Apr 16, 2025

Thanks!

@arunchndr arunchndr disabled auto-merge April 18, 2025 17:40
@arunchndr arunchndr merged commit 749a789 into dotnet:main Apr 18, 2025
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Apr 18, 2025
@Rekkonnect Rekkonnect deleted the fix/78171-pp-quick-info branch April 18, 2025 17:46
This was referenced Apr 21, 2025
Closed
Closed
@CyrusNajmabadi
Copy link
Member

CyrusNajmabadi commented Apr 24, 2025

Thanks!

@Rekkonnect Rekkonnect mentioned this pull request May 14, 2025
Closed
@dotnet-bot dotnet-bot mentioned this pull request May 31, 2025
Closed
@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Jul 4, 2025
Merged
@RikkiGibson RikkiGibson modified the milestones: Next, 18.0 P1 Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees

No one assigned

Labels

Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead VSCode

Projects

None yet

Milestone

18.0 P1

Development

Successfully merging this pull request may close these issues.

Preprocessing directives not handled correctly in CommonSemanticQuickInfoProvider.BindToken(

4 participants

@Rekkonnect @CyrusNajmabadi @RikkiGibson @arunchndr