Add cherry pick parameters to pipeline #78178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Infrastructure
untriaged
dibarbet
force-pushed
the
dev/dibarbet/cherry_pick_pipeline
branch
from
0844d9e to
aaa80ec
Compare
jaredpar
reviewed
Apr 17, 2025
| type: boolean | ||
| default: true | ||
|
|
||
| - name: VisualStudioCherryPickSHA |
Member
There was a problem hiding this comment.
Not clear what this does ... can you add a comment describing what this parameter is used for?
Member
There was a problem hiding this comment.
Oh ... so this lets us pick a commit of VS that we want to run against? Basically means we can retest a change against the same VS baseline?
Member
Author
There was a problem hiding this comment.
not exactly - it allows us to cherry-pick a commit from another VS branch onto our insertion branch. For example if we need to do a dual insertion, or a roslyn change requires another VS-side change. Instead of having to wait for the PR to be created, then cherry-pick it over, the roslyn insertion tool can do it when it creates the insertion
jaredpar
approved these changes
Apr 17, 2025
This was referenced Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation - https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/629206