Test some IDE scenarios for instance operators #78186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
untriaged
3 tasks
Contributor
Author
|
@CyrusNajmabadi Please review |
| class C : {|CS0535:ITest|} | ||
| { | ||
| } | ||
| namespace System.Runtime.CompilerServices |
Member
There was a problem hiding this comment.
given the test duplication, my preference is this is pulled into a constant at the start of the file and included in the tests that need it. if you're on a time crunch, this isn't blocking, and i can do that as a followup. But if it's simple (and/or copilot can help :)) then that would be appreciated. #Resolved
Contributor
Author
There was a problem hiding this comment.
my preference is this is pulled into a constant at the start of the file and included in the tests that need it.
Will do
CyrusNajmabadi
approved these changes
Apr 17, 2025
Contributor
Author
|
@CyrusNajmabadi Are we good to merge with a single sign-off? |
Member
|
Yup! |
AlekseyTs
merged commit 6c8b098
into
dotnet:features/UserDefinedCompoundAssignment
25 checks passed
This was referenced May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.