Reapply "Remove EditorFeatures from OOP (#78069)" (#78179) #78194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ryzngard
commented
Apr 17, 2025
ryzngard
commented
- Reapply "Remove EditorFeatures from OOP (Remove EditorFeatures from OOP #78069)" (Revert "Remove EditorFeatures from OOP (#78069)" #78179)
- Fix missing VSIX, IVT, and PublishData changes
added 2 commits
April 17, 2025 14:32
ghost
added
Area-IDE
untriaged
Contributor
Author
dibarbet
reviewed
Apr 17, 2025
| "Microsoft.CodeAnalysis.ExternalAccess.OmniSharp": "arcade", | ||
| "Microsoft.CodeAnalysis.ExternalAccess.OmniSharp.CSharp": "arcade", | ||
| "Microsoft.CodeAnalysis.ExternalAccess.AspNetCore": "vs-impl", | ||
| "Microsoft.CodeAnalysis.ExternalAccess.Razor": "vs-impl", |
Member
There was a problem hiding this comment.
Don't remove this, we need it for servicing branches
Contributor
Author
There was a problem hiding this comment.
oh interesting. Does the publish data only come from one branch?
Member
There was a problem hiding this comment.
yep, only main. we kind of want to change it, but haven't yet
CyrusNajmabadi
approved these changes
Apr 17, 2025
dibarbet
approved these changes
Apr 17, 2025
Member
dibarbet
left a comment
dibarbet
left a comment
There was a problem hiding this comment.
Pending current insertions getting in, then .net 10 changes, then we take this.
This was referenced Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.