Allocate slightly less in ImmutableArrayExtensions.ConditionallyDeOrder #78235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method currently allocates two arrays (once during the ToArray call, the other in the AsImmutable call). This is generally not a problem as this is debug only code, but this method is called very frequently, so I'll change the line to make this method only allocate the array once.
ghost
added
Area-Compilers
untriaged
CyrusNajmabadi
approved these changes
Apr 21, 2025
Contributor
|
@dotnet/roslyn-compiler For the second review |
cston
approved these changes
Apr 22, 2025
This was referenced Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method currently allocates two arrays (once during the ToArray call, the other in the AsImmutable call). This is generally not a problem as this is debug only code, but this method is called very frequently, so I'll change the line to make this method only allocate the array once.