Skip to content

Fix toolset package failing to build from clean state in VS #78251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2025
Merged

Fix toolset package failing to build from clean state in VS #78251

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4950cbe
Fix toolset package not building from clean state in VS
jjonescz Apr 22, 2025
ccbab07
Simplify the build targets for copying files
jasonmalinowski Apr 22, 2025
2d939b2
Fix indenting
jasonmalinowski Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions ...Get/Microsoft.Net.Compilers.Toolset/AnyCpu/Microsoft.Net.Compilers.Toolset.Package.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,18 @@

This package is primarily intended as a method for rapidly shipping hotfixes to customers. Using it as a long term solution for providing newer compilers on older MSBuild installations is explicitly not supported. That can and will break on a regular basis.

The supported mechanism for providing new compilers in a build enviroment is updating to the newer .NET SDK or Visual Studio Build Tools SKU.
The supported mechanism for providing new compilers in a build environment is updating to the newer .NET SDK or Visual Studio Build Tools SKU.
Copy link
Member

@jaredpar jaredpar Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that there was any doubt, but I did a git blame and yeah this was my fault.


This package requires either MSBuild 16.3 and .NET Desktop 4.7.2+ or .NET Core 2.1+

$(RoslynPackageDescriptionDetails)
</PackageDescription>
<TargetsForTfmSpecificContentInPackage>$(TargetsForTfmSpecificContentInPackage);_GetFiles</TargetsForTfmSpecificContentInPackage>
<!-- Remove NU5128 once https://github.com/NuGet/Home/issues/8583 is fixed -->
<NoWarn>$(NoWarn);NU5100;NU5128</NoWarn>

<_DependsOn Condition="'$(TargetFramework)' == 'net472'">InitializeDesktopCompilerArtifacts</_DependsOn>
<_DependsOn Condition="'$(TargetFramework)' != 'net472'">InitializeCoreClrCompilerArtifacts</_DependsOn>
<_InitializeArtifactsTargetName Condition="'$(TargetFramework)' == 'net472'">InitializeDesktopCompilerArtifacts</_InitializeArtifactsTargetName>
<_InitializeArtifactsTargetName Condition="'$(TargetFramework)' != 'net472'">InitializeCoreClrCompilerArtifacts</_InitializeArtifactsTargetName>
</PropertyGroup>

<ItemGroup>
Expand All @@ -46,7 +47,7 @@
<Content Include="buildMultiTargeting\**\*.*" PackagePath="buildMultiTargeting\" />
</ItemGroup>

<Target Name="_GetFiles" AfterTargets="Build" DependsOnTargets="$(_DependsOn)" Condition="'$(TargetFramework)' != ''">
<Target Name="_GetFiles" DependsOnTargets="$(_InitializeArtifactsTargetName);Build">
<ItemGroup>
<_File Include="@(DesktopCompilerArtifact)" TargetDir="tasks/net472"/>
<_File Include="@(DesktopCompilerResourceArtifact)" TargetDir="tasks/net472"/>
Expand All @@ -61,7 +62,8 @@
<TfmSpecificPackageFile Include="@(_FileWithPath)" PackagePath="%(_FileWithPath.TargetPath)" />
</ItemGroup>

<!-- Used for debugging parts of the toolset (e.g., build tasks). -->
<!-- Used for debugging parts of the toolset (e.g., build tasks).
Doesn't work in VS (where `<ProjectReference Targets="Publish" />` doesn't have any effect), hence we set `ContinueOnError="true"`. -->
Copy link
Member

@jasonmalinowski jasonmalinowski Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh I forgot to delete this comment.

<Copy SourceFiles="@(_FileWithPath)"
DestinationFiles="$(BaseOutputPath)$(Configuration)\%(_FileWithPath.TargetPath)"
SkipUnchangedFiles="true" />
Expand Down