Edit & Continue support for field access in auto-properties #78289
Conversation
VB Note: EditingTestBase.vb already specifies LanguageVersion.Latest when parsing.
This is needed to support EnC for auto-props using the field keyword.
ghost
added
Area-Interactive
untriaged
| "Update [=> 1]@16 -> [=> field]@16"); | ||
|
|
||
| edits.VerifySemantics( | ||
| [SemanticEdit(SemanticEditKind.Update, c => c.GetMember<IPropertySymbol>("C.P").GetMethod)], |
There was a problem hiding this comment.
I can't remember, should this also have a field add in the list of edits? Or is that bit automatic for properties?
Perhaps a test in https://github.com/dotnet/roslyn/blob/main/src/Compilers/CSharp/Test/Emit2/Emit/EditAndContinue/EditAndContinueTests.cs would be a good idea, to make sure the right metadata is emitted.
There was a problem hiding this comment.
Should this also have a field add in the list of edits?
I don't believe so. At least, I don't see an insert for the backing field in other auto-property tests. The insert of the field is implicitly tested by verifying the diagnostics below when the AddInstanceFieldToExistingType capability isn't specified. I'll take a look at adding a test or two on the compiler side as well.
There was a problem hiding this comment.
The insert of the field is implicitly tested by verifying the diagnostics below when the AddInstanceFieldToExistingType capability isn't specified.
I missed this, that's a very good point.
There was a problem hiding this comment.
Added compiler layer tests
There was a problem hiding this comment.
We don't need the field insert. We just need to tell the compiler to emit the property and it will emit all symbols it needs to do so.
| validator: g => | ||
| { | ||
| g.VerifyTypeDefNames("HotReloadException"); | ||
| g.VerifyFieldDefNames("Code"); |
There was a problem hiding this comment.
It's from HotReloadException.Code.
|
@tmat: Is there anything you need before giving sign off? |
4 participants
Fixes #77951
Field access in auto-properties mostly already worked in EnC.
AbstractEditAndContinueAnalyzerto allow auto-properties to be detected from a set accessor.cc @tmat