Precursor work to merge EditorFeatures.WPF into EditorFeatures. #78308
Conversation
ghost
added
Area-IDE
untriaged
src/EditorFeatures/Core/Microsoft.CodeAnalysis.EditorFeatures.csproj
Outdated
Show resolved
Hide resolved
|
|
||
| namespace Microsoft.VisualStudio.LanguageServices.Xaml.Features.Peek; | ||
|
|
||
| internal interface IXamlPeekableItemFactory |
There was a problem hiding this comment.
new EA layer code for xaml to use.
|
@jasonmalinowski ptal. |
dibarbet
left a comment
dibarbet
left a comment
There was a problem hiding this comment.
Fine with the change overall, but holding off on approval until the PR validation comes back.
SUre. Teh build has been kicked off. will report back on results. |
src/EditorFeatures/Core/Microsoft.CodeAnalysis.EditorFeatures.csproj
Outdated
Show resolved
Hide resolved
src/EditorFeatures/CSharp/Microsoft.CodeAnalysis.CSharp.EditorFeatures.csproj
Outdated
Show resolved
Hide resolved
jasonmalinowski
left a comment
jasonmalinowski
left a comment
There was a problem hiding this comment.
Approved, but there's still one line that's concerning about CodeLens, but I presume if we break that internal tests will make it very clear to us.
src/EditorFeatures/CSharp/InlineRename/CSharpEditorInlineRenameService.cs
Outdated
Show resolved
Hide resolved
src/EditorFeatures/CSharp/StringCopyPaste/StringCopyPasteData.cs
Outdated
Show resolved
Hide resolved
| <RootNamespace>Microsoft.CodeAnalysis.ExternalAccess.Debugger</RootNamespace> | ||
| <TargetFramework>netstandard2.0</TargetFramework> | ||
| <TargetFramework>net472</TargetFramework> | ||
| <UseWPF>true</UseWPF> |
There was a problem hiding this comment.
I don't imagine this change was necessary? This reminds me of the other CodeLens change you weren't sure about.
There was a problem hiding this comment.
No. this debugger lib def talks to EditorFEatures. it is @tmat 's EA layer so that he can populate the FAR window with symbolic results. He'd have to say why this is needed. BUt it will def have to change like this.
src/EditorFeatures/VisualBasic/Microsoft.CodeAnalysis.VisualBasic.EditorFeatures.vbproj
Outdated
Show resolved
Hide resolved
| <ProjectReference Include="$(MSBuildThisFileDirectory)..\ServiceHub\Microsoft.CodeAnalysis.Remote.ServiceHub.csproj" /> | ||
| <ProjectReference Include="$(MSBuildThisFileDirectory)..\..\..\Features\CSharp\Portable\Microsoft.CodeAnalysis.CSharp.Features.csproj" /> | ||
| <ProjectReference Include="$(MSBuildThisFileDirectory)..\..\..\Features\VisualBasic\Portable\Microsoft.CodeAnalysis.VisualBasic.Features.vbproj" /> | ||
| <!-- CodeLens provider is not part of Roslyn ServiceHub, we just use the existing ServiceHub package as a delivery vehicle --> |
There was a problem hiding this comment.
So was this comment wrong that we weren't using it as a delivery vehicle? Or does this need to be undone with the other CodeLens changes?
There was a problem hiding this comment.
yeah. this needs to be undone. it broke VS insertion. But i don't understand why. It seems bad that we depend on this line here for things to work. i would love your help on understanding that @JoeRobich @jasonmalinowski @ToddGrun .
|
Test insertion is clean. Merging this in. |
5 participants
This moves everything down, except for special code we expose to Xaml to allow them to use our Peek service. This PR also adds code into their existing EA layer to do this instead.
So we can:
Precursor to #77707
Build: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=11516158&view=results
PR: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/633485