*** WIP: Optimize work done in ProjectCodeModelFactory #78337
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there were any questions about the event needing the main thread, this PR attempts to be safe in the assumptions. Future PRs can judiciously look at moving event handlers to work on background threads.
Will add more details if a speedometer run shows a marked improvement in the CPU work done in this class.
ghost
added
Area-IDE
untriaged
ToddGrun
changed the title
Contributor
Author
|
Superseded by #78369 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*** WIP: Optimize work done in ProjectCodeModelFactory
The first 3 commits in this PR are the work from #78333. The final commit is the payload of this PR, as it builds on 78333 and that has not yet been merged. I didn't want to include this in that PR as it's a separate concern.
Test insertion PR: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/631967
Speedometer results came back looking good. Will create a real PR for this once 78333 is finished.
*** old CPU under ProjectCodeModelFactory ***
*** old allocs under ProjectCodeModelFactory ***
*** new CPU under ProjectCodeModelFactory ***
*** new allocs under ProjectCodeModelFactory ***
