Make IDiagnosticAnalyzerService into an IWorkspaceService #78359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Analyzers
untriaged
CyrusNajmabadi
commented
Apr 28, 2025
| [method: Obsolete(MefConstruction.ImportingConstructorMessage, error: true)] | ||
| internal sealed class CSharpCodeCleanupService(ICodeFixService codeFixService, IDiagnosticAnalyzerService diagnosticAnalyzerService) : AbstractCodeCleanupService(codeFixService, diagnosticAnalyzerService) | ||
| internal sealed class CSharpCodeCleanupService(ICodeFixService codeFixService) | ||
| : AbstractCodeCleanupService(codeFixService) |
Member
Author
There was a problem hiding this comment.
most changes are just not passing the IDiagAnalzyerService along. INstead, code that needs it, requests it as a normal workspace service at the point they actually need it.
CyrusNajmabadi
commented
Apr 28, 2025
|
|
||
| // When the workspace changes what context a document is in (when a user picks a different tfm to view the | ||
| // document in), kick off a refresh so that diagnostics properly update in the task list and editor. | ||
| workspace.RegisterDocumentActiveContextChangedHandler(args => RequestDiagnosticRefresh()); |
Member
Author
There was a problem hiding this comment.
moved registration here, which is much cleaner than when we were originally creating the incremetnal analyzers.
CyrusNajmabadi
commented
Apr 28, 2025
| => _diagnosticsRefresher.RequestWorkspaceRefresh(); | ||
|
|
||
| private DiagnosticIncrementalAnalyzer CreateIncrementalAnalyzer(Workspace workspace) | ||
| => _map.GetValue(workspace, _createIncrementalAnalyzer); |
Member
Author
There was a problem hiding this comment.
move from deleted sibling file (which should be looked at).
CyrusNajmabadi
commented
Apr 28, 2025
| private DiagnosticIncrementalAnalyzer CreateIncrementalAnalyzerCallback(Workspace workspace) | ||
| { | ||
| // subscribe to active context changed event for new workspace | ||
| _ = workspace.RegisterDocumentActiveContextChangedHandler(args => RequestDiagnosticRefresh()); |
Member
Author
There was a problem hiding this comment.
moved to constructor.
dibarbet
approved these changes
Apr 28, 2025
Member
dibarbet
left a comment
dibarbet
left a comment
There was a problem hiding this comment.
this seems reasonable. agree that it would be nice if the refresher was a workspace service too, but fine with leaving that out due to the EA restrictions
This was referenced May 1, 2025
CyrusNajmabadi
added a commit
to CyrusNajmabadi/roslyn
that referenced
this pull request
May 7, 2025
Followup to dotnet#78356. Needed so we can access IDiagAnalyzerService in OOP. Currently one cannot as it attempts to access the Workspace of a document passed into it. We block WOrkspace access like for safety/clarity concerns (we don't want a stateless OOP api call to have access to the mutable workspace API). This also cleans up some ugly initialization code IDiagAnalyzerService had.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #78356.
Needed so we can access IDiagAnalyzerService in OOP. Currently one cannot as it attempts to access the Workspace of a document passed into it. We block WOrkspace access like for safety/clarity concerns (we don't want a stateless OOP api call to have access to the mutable workspace API).
This also cleans up some ugly initialization code IDiagAnalyzerService had.