Add legacy workspace eventing APIs to the banned list inside roslyn #78370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Infrastructure
untriaged
CyrusNajmabadi
approved these changes
Apr 29, 2025
jasonmalinowski
approved these changes
Apr 29, 2025
eng/config/BannedSymbols.txt
Outdated
| M:Microsoft.CodeAnalysis.DesktopStrongNameProvider.#ctor(System.Collections.Immutable.ImmutableArray{System.String}); Use overload that takes in temp directory | ||
| M:System.Diagnostics.Tracing.EventSource.WriteEvent(System.Int32,System.Object[]); Use WriteEventCore instead | ||
| M:System.Diagnostics.Tracing.EventSource.WriteEvent(System.Int32,System.Object[]); Use WriteEventCore instead | ||
| E:Microsoft.CodeAnalysis.Workspace.WorkspaceChanged |
Member
There was a problem hiding this comment.
Consider adding the comment explaining what to use instead; even if we know it's still helpful to be self-documenting why these lines are here.
| /// Sets the <see cref="CurrentSolution"/> of this workspace. This method does not raise a <see | ||
| /// cref="WorkspaceChanged"/> event. This method should be used <em>sparingly</em>. As much as possible, | ||
| /// derived types should use the SetCurrentSolution overloads that take a transformation. | ||
| /// cref="WorkspaceEventType.WorkspaceChange"/> event. This method should be used <em>sparingly</em>. |
Member
There was a problem hiding this comment.
We may need to suppress the pragma here -- I'm not sure if this will trip up any documentation generators since this is now going to an internal type instead.
Contributor
Author
There was a problem hiding this comment.
bah, the cref isn't that important. The comment is pretty clear without it.
This was referenced May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.