Make compiler detection more resilient #78402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the way our build task finds the csc to launch to longer depend on the `CompilerType` task argument. At the core for every deployment kind of the task there is only one possible compiler that can be loaded. Hence change our logic to better assert which deployment we are in and locate the compiler based on that.
ghost
added
Area-Compilers
untriaged
jjonescz
approved these changes
May 2, 2025
| using Microsoft.CodeAnalysis.BuildTasks.UnitTests.TestUtilities; | ||
| using Xunit.Abstractions; | ||
| using Microsoft.CodeAnalysis.Test.Utilities; | ||
| using System.Reflection; |
jjonescz
reviewed
May 5, 2025
jjonescz
reviewed
May 5, 2025
Member
Author
|
@dotnet/roslyn-compiler PTAL |
Member
Author
|
@333fred, @chsienki, @RikkiGibson PTAL |
jcouv
reviewed
May 6, 2025
jcouv
reviewed
May 6, 2025
jcouv
reviewed
May 6, 2025
jcouv
reviewed
May 6, 2025
jcouv
reviewed
May 6, 2025
jcouv
reviewed
May 6, 2025
jcouv
reviewed
May 6, 2025
jcouv
reviewed
May 6, 2025
Member
jcouv
left a comment
jcouv
left a comment
There was a problem hiding this comment.
Done with review pass (iteration 8). Only some minor nits/typos
333fred
approved these changes
May 6, 2025
Co-authored-by: Fred Silberberg <fred@silberberg.xyz>
Member
|
is this backported to preview4 ? |
Member
|
@rmarinho no, it's not, it will be in preview5. Are you hitting some issues that need this and don't have a workaround? |
Member
|
Yeah we are hitting this in .NET MAUI and VisualStudio . @jaredpar suggest a workaround Full but seems it doesn t work in all cases. |
Member
|
Can you link an issue that we can investigate? |
This was referenced May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the way our build task finds the csc to launch to longer depend on the
CompilerTypetask argument. At the core for every deployment kind of the task there is only one possible compiler that can be loaded. Hence change our logic to better assert which deployment we are in and locate the compiler based on that.This removes the need to add extra parameters to every
<Csc>invocation which was causing issues in .NET 10 SDK