Fixes #7470 NRE in build task #7841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -93,13 +93,14 @@ internal int RunCompilation(IEnumerable<string> originalArguments, BuildPaths bu | |||
| return HandleResponse(buildResponse, parsedArgs, buildPaths); | |||
| } | |||
| } | |||
| catch | |||
| catch (OperationCanceledException) | |||
There was a problem hiding this comment.
Other exceptions will still be caught further down the stack, right?
There was a problem hiding this comment.
Yes, all server exceptions should be caught by RunServerCompilation. By the time we get here we shouldn't be swallowing exceptions.
|
👍 |
| @@ -157,12 +157,12 @@ protected override int RunLocalCompilation(List<string> arguments, string client | |||
| } | |||
| } | |||
|
|
|||
| return null; | |||
| return Task.FromResult<BuildResponse>(null); | |||
There was a problem hiding this comment.
Why does this method have to return Task<BuildResponse> instead of just BuildResponse? There are no await's here. Or is it to make the signature equivalent to another function that does use await?
There was a problem hiding this comment.
I spoke with @agocke offline and he explained what was going on.
There was a problem hiding this comment.
I swear we should write a rule that flags returning null from a Task based method 😦
| @@ -13,6 +13,7 @@ | |||
| using System.Threading.Tasks; | |||
| using Microsoft.CodeAnalysis.Test.Utilities; | |||
| using Roslyn.Test.Utilities; | |||
| using System.Threading; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.