Move RestoreUseStaticGraphEvaluation setting inside repo #78429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted from dotnet/dotnet#176 The above PR removes the DotNetBuild.props VMR / SB entrypoint. All settings will move into the repo infra. The RestoreUseStaticGraphEvaluation property needs to be set before Arcade's Build.proj builds the solution and in the repo infra so that dotnet/msbuild/NuGet commands use that restore mode. Therefore, also define it in eng/Build.props which is imported by Build.proj and remove the prop from the build scripts. Move the DotNetBuild condition inline into the two places that now set it.
ghost
added
Area-Infrastructure
untriaged
11 tasks
jjonescz
approved these changes
May 5, 2025
jjonescz
reviewed
May 5, 2025
src/EditorFeatures/Core/Microsoft.CodeAnalysis.EditorFeatures.csproj
Outdated
Show resolved
Hide resolved
Member
Author
|
@jjonescz can you please merge the PR in? |
Member
Member
Author
|
/ba-g Build Analysis is stuck |
…eSettingOutOfScriptsAndVMREntryPoint
ViktorHofer
deleted the
MoveStaticGraphRestoreSettingOutOfScriptsAndVMREntryPoint
branch
This was referenced May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from dotnet/dotnet#176 - which removes the DotNetBuild.props VMR / SB entrypoint. All settings will move into the repo infra eventually.
The
RestoreUseStaticGraphEvaluationproperty needs to be set before Arcade's Build.proj builds the solution and in the repo infra so that dotnet/msbuild/NuGet commands use that static graph restore. This works today by passing the property in as a global property in the build scripts. Source-build has issues with static graph which is why it was disabled in DotNetBuild.props. As we now move settings from DotNetBuild.props into the repo infra, define that in eng/Build.props (Arcade extension point) and remove the unnecessary global property from the build scripts.Also set
RestoreUseStaticGraphEvaluationin Directory.Solution.props so that VS uses the same restore algorithm.Unrelated: Add the short
-sbform for--sourcebuildin eng/build.sh. Arcade's eng/common support the short form.