Add WorkItem trait discoverer #78438
Conversation
ghost
added
Area-Compilers
untriaged
| var arguments = traitAttribute.GetConstructorArguments().ToArray(); | ||
| if (arguments is [int id, string url]) | ||
| { | ||
| yield return new KeyValuePair<string, string>("WorkItemId", id.ToString()); |
There was a problem hiding this comment.
Where do "WorkItemId" and "WorkItemUrl" show up? Do we have to type a query like Trait: "WorkItemId=12345" or would Trait: 12345 work? #Closed
There was a problem hiding this comment.
The latter works. I think you could write the former to be more specific though.
| } | ||
| else if (arguments is [string onlyUrl]) | ||
| { | ||
| yield return new KeyValuePair<string, string>("WorkItemUrl", onlyUrl); |
There was a problem hiding this comment.
In the case where the WorkItem only contains a URL (which is what we now commonly do), maybe we should extract the ID and make it available to search on too? #Closed
There was a problem hiding this comment.
Even if there is just WorkItem(url) attribute, searching for Trait:IssueId works as well (i.e., a substring match is enough)
| { | ||
| public IEnumerable<KeyValuePair<string, string>> GetTraits(IAttributeInfo traitAttribute) | ||
| { | ||
| var arguments = traitAttribute.GetConstructorArguments().ToArray(); |
There was a problem hiding this comment.
Should we check that we're dealing with the WorkItem attribute? #Closed
There was a problem hiding this comment.
We could but it's not necessary - the WorkItemTraitDiscoverer is only used for WorkItemAttribute thanks to the corresponding [TraitDiscoverer("Microsoft.CodeAnalysis.Test.Utilities.WorkItemTraitDiscoverer", assemblyName: "Microsoft.CodeAnalysis.Test.Utilities")]. This is modeled after https://github.com/dotnet/roslyn/blob/3f3096be868cee0fa3d99875da1739caeb742553/src/Compilers/Test/Core/Traits/CompilerTraitDiscoverer.cs which also doesn't check the attribute type
|
|
||
| namespace Microsoft.CodeAnalysis.Test.Utilities; | ||
|
|
||
| public sealed class WorkItemTraitDiscoverer : ITraitDiscoverer |
There was a problem hiding this comment.
Allows searching for tests marked with WorkItemAttribute, e.g., in VS Test Explorer via Trait:"...issue url..."
Could you give an example/screenshot of what the experience looks like once the discoverer is in place?
There was a problem hiding this comment.
Added screenshot to PR description.
4 participants
Allows searching for tests marked with
WorkItemAttribute, e.g., in VS Test Explorer viaTrait:"...issue url..."orTrait:IssueNumber: