Skip to content

Unset CompilerType from Csc #78483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025
Merged

Unset CompilerType from Csc #78483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bcba80
Unset CompilerType from Csc
jjonescz May 7, 2025
2e98882
Remove CompilerType logic
jjonescz May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Compilers/Core/MSBuildTask/ManagedCompiler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,10 +487,11 @@ public bool ReportIVTs
get { return _store.GetOrDefault(nameof(ReportIVTs), false); }
}

// Keeping this for a while to avoid failures if someone uses sdk targets that still set this.
public string? CompilerType
{
set { _store[nameof(CompilerType)] = value; }
get { return (string?)_store[nameof(CompilerType)]; }
set { }
get { return null; }
}

#endregion
Expand Down
1 change: 0 additions & 1 deletion src/Compilers/Core/MSBuildTask/Microsoft.CSharp.Core.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@
ChecksumAlgorithm="$(ChecksumAlgorithm)"
CodeAnalysisRuleSet="$(ResolvedCodeAnalysisRuleSet)"
CodePage="$(CodePage)"
CompilerType="$(RoslynCompilerType)"
DebugType="$(DebugType)"
DefineConstants="$(DefineConstants)"
DelaySign="$(DelaySign)"
Expand Down
1 change: 0 additions & 1 deletion src/Compilers/Core/MSBuildTask/Microsoft.VisualBasic.Core.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@
ChecksumAlgorithm="$(ChecksumAlgorithm)"
CodeAnalysisRuleSet="$(ResolvedCodeAnalysisRuleSet)"
CodePage="$(CodePage)"
CompilerType="$(RoslynCompilerType)"
Copy link
Member

@jcouv jcouv May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider leaving a comment on ManagedCompiler.CompilerType and removing the logic it contains

DebugType="$(DebugType)"
DefineConstants="$(FinalDefineConstants)"
DelaySign="$(DelaySign)"
Expand Down