Delay loading of CodeRefactoringProvider's till absolutely needed #78495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
dotnet-policy-service
bot
added
Community
src/Features/Core/Portable/CodeRefactorings/CodeRefactoringService.cs
Outdated
Show resolved
Hide resolved
dibarbet
reviewed
May 7, 2025
src/Features/Core/Portable/CodeRefactorings/CodeRefactoringService.cs
Outdated
Show resolved
Hide resolved
src/Features/Core/Portable/CodeRefactorings/CodeRefactoringService.cs
Outdated
Show resolved
Hide resolved
dibarbet
approved these changes
May 7, 2025
src/Features/Core/Portable/CodeRefactorings/CodeRefactoringService.cs
Outdated
Show resolved
Hide resolved
src/Features/Core/Portable/CodeRefactorings/OrderableLanguageDocumentMetadata.cs
Show resolved
Hide resolved
src/EditorFeatures/Test/CodeRefactorings/CodeRefactoringServiceTest.cs
Outdated
Show resolved
Hide resolved
|
|
||
| foreach (var type in expectedProviderTypes) | ||
| { | ||
| Assert.Contains(actualProviders, p => p.GetType() == type); |
There was a problem hiding this comment.
We have an AssertEx.SetEqual() helper for doing set comparisons.
There was a problem hiding this comment.
Actual set are CodeRefactorerProvider instances. Expected set are the types of those instances.
There was a problem hiding this comment.
You could say AssertEx.SetEqual(expectedProviderTypes, actualProviders.Select(p => p.GetType()) then.
(leave this as is though unless you need to do a follow-up for something else)
src/Features/Core/Portable/CodeRefactorings/CodeRefactoringService.cs
Outdated
Show resolved
Hide resolved
This was referenced May 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delay loading of CodeRefactoringProvider's till absolutely needed. For example, we do not want to load refactoring provider for AdditonalDocument XAML files unless user is editing such files.