Source package fixes

Roslyn.sln

@@ -2269,6 +2269,8 @@ Global
 		src\Dependencies\CodeAnalysis.Debugging\Microsoft.CodeAnalysis.Debugging.projitems*{edc68a0e-c68d-4a74-91b7-bf38ec909888}*SharedItemsImports = 5
 		src\Dependencies\Contracts\Microsoft.CodeAnalysis.Contracts.projitems*{fa0e905d-ec46-466d-b7b2-3b5557f9428c}*SharedItemsImports = 5
 		src\ExpressionEvaluator\Core\Source\ResultProvider\ResultProvider.projitems*{fa0e905d-ec46-466d-b7b2-3b5557f9428c}*SharedItemsImports = 5
+		src\Dependencies\Contracts\Microsoft.CodeAnalysis.Contracts.projitems*{fc2ae90b-2e4b-4045-9fdd-73d4f5ed6c89}*SharedItemsImports = 5
+		src\Dependencies\PooledObjects\Microsoft.CodeAnalysis.PooledObjects.projitems*{fc2ae90b-2e4b-4045-9fdd-73d4f5ed6c89}*SharedItemsImports = 5
 		src\RoslynAnalyzers\Utilities\FlowAnalysis\FlowAnalysis.Utilities.projitems*{fcb56cba-fa35-46a8-86b7-bae5433197d9}*SharedItemsImports = 13
 		src\RoslynAnalyzers\Utilities\Compiler\Analyzer.Utilities.projitems*{fce0046b-03f8-78f6-86a1-8ddcee8f4c9f}*SharedItemsImports = 5
 		src\Dependencies\Contracts\Microsoft.CodeAnalysis.Contracts.projitems*{fce88bbd-9bbd-4871-b9b0-de176d73a6b0}*SharedItemsImports = 5

src/Dependencies/.editorconfig

@@ -0,0 +1,6 @@
+[*.cs]
+
+# IDE0240: Remove redundant nullable directive
+# The directive needs to be included since all sources in a source package are considered generated code
+# when referenced from a project via package reference.
+dotnet_diagnostic.IDE0240.severity = none

src/Dependencies/CodeAnalysis.Debugging/CustomDebugInfoConstants.cs

@@ -2,6 +2,8 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+#nullable enable
+
 namespace Microsoft.CodeAnalysis.Debugging
 {
     /// <summary>

src/Dependencies/CodeAnalysis.Debugging/CustomDebugInfoEncoder.cs

@@ -2,7 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-#nullable disable
+#nullable enable
 
 using System;
 using System.Collections.Generic;
@@ -40,7 +40,7 @@ public CustomDebugInfoEncoder(BlobBuilder builder)
         public readonly int RecordCount => _recordCount;
 
         /// <exception cref="InvalidOperationException">More than <see cref="byte.MaxValue"/> records added.</exception>
-        public readonly byte[] ToArray()
+        public readonly byte[]? ToArray()
         {
             if (_recordCount == 0)
             {
@@ -54,8 +54,6 @@ public readonly byte[] ToArray()
 
         public void AddStateMachineTypeName(string typeName)
         {
-            Debug.Assert(typeName != null);
-
             AddRecord(
                 CustomDebugInfoKind.StateMachineTypeName,
                 typeName,
@@ -142,8 +140,6 @@ public void AddStateMachineHoistedLocalScopes(ImmutableArray<StateMachineHoisted
 
         public void AddDynamicLocals(IReadOnlyCollection<(string LocalName, byte[] Flags, int Count, int SlotIndex)> dynamicLocals)
         {
-            Debug.Assert(dynamicLocals != null);
-
             AddRecord(
                 CustomDebugInfoKind.DynamicLocals,
                 dynamicLocals,
@@ -168,8 +164,6 @@ public void AddDynamicLocals(IReadOnlyCollection<(string LocalName, byte[] Flags
 
         public void AddTupleElementNames(IReadOnlyCollection<(string LocalName, int SlotIndex, int ScopeStart, int ScopeEnd, ImmutableArray<string> Names)> tupleLocals)
         {
-            Debug.Assert(tupleLocals != null);
-
             AddRecord(
                 CustomDebugInfoKind.TupleElementNames,
                 tupleLocals,

src/Dependencies/CodeAnalysis.Debugging/CustomDebugInfoKind.cs

@@ -2,7 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-#nullable disable
+#nullable enable
 
 namespace Microsoft.CodeAnalysis.Debugging
 {

src/Dependencies/CodeAnalysis.Debugging/CustomDebugInfoReader.cs

@@ -2,12 +2,13 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-#nullable disable
+#nullable enable
 
 using System;
 using System.Collections.Generic;
 using System.Collections.Immutable;
 using System.Diagnostics;
+using System.Diagnostics.CodeAnalysis;
 using System.Globalization;
 using System.Text;
 using Microsoft.CodeAnalysis.PooledObjects;
@@ -313,7 +314,7 @@ public static ImmutableArray<TupleElementNamesInfo> DecodeTupleElementNamesRecor
         private static TupleElementNamesInfo DecodeTupleElementNamesInfo(ImmutableArray<byte> bytes, ref int offset)
         {
             var n = ReadInt32(bytes, ref offset);
-            var builder = ArrayBuilder<string>.GetInstance(n);
+            var builder = ArrayBuilder<string?>.GetInstance(n);
             for (var i = 0; i < n; i++)
             {
                 var value = ReadUtf8String(bytes, ref offset);
@@ -337,7 +338,7 @@ private static TupleElementNamesInfo DecodeTupleElementNamesInfo(ImmutableArray<
         public static ImmutableArray<ImmutableArray<string>> GetCSharpGroupedImportStrings<TArg>(
             int methodToken,
             TArg arg,
-            Func<int, TArg, byte[]> getMethodCustomDebugInfo,
+            Func<int, TArg, byte[]?> getMethodCustomDebugInfo,
             Func<int, TArg, ImmutableArray<string>> getMethodImportStrings,
             out ImmutableArray<string> externAliasStrings)
         {
@@ -572,7 +573,7 @@ private static bool IsCSharpExternAliasInfo(string import)
         ///  "TSystem.Math" -> <type name="System.Math" />
         /// ]]>
         /// </remarks>
-        public static bool TryParseCSharpImportString(string import, out string alias, out string externAlias, out string target, out ImportTargetKind kind)
+        public static bool TryParseCSharpImportString(string import, out string? alias, out string? externAlias, out string? target, out ImportTargetKind kind)
         {
             alias = null;
             externAlias = null;
@@ -673,7 +674,7 @@ public static bool TryParseCSharpImportString(string import, out string alias, o
         /// </summary>
         /// <exception cref="ArgumentNullException"><paramref name="import"/> is null.</exception>
         /// <exception cref="ArgumentException">Format of <paramref name="import"/> is not valid.</exception>
-        public static bool TryParseVisualBasicImportString(string import, out string alias, out string target, out ImportTargetKind kind, out VBImportScopeKind scope)
+        public static bool TryParseVisualBasicImportString(string import, out string? alias, out string? target, out ImportTargetKind kind, out VBImportScopeKind scope)
         {
             alias = null;
             target = null;
@@ -820,7 +821,7 @@ public static bool TryParseVisualBasicImportString(string import, out string ali
             }
         }
 
-        private static bool TrySplit(string input, int offset, char separator, out string before, out string after)
+        private static bool TrySplit(string input, int offset, char separator, [NotNullWhen(true)] out string? before, [NotNullWhen(true)] out string? after)
         {
             var separatorPos = input.IndexOf(separator, offset);
 

src/Dependencies/CodeAnalysis.Debugging/CustomDebugInfoRecord.cs

@@ -2,7 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-#nullable disable
+#nullable enable
 
 using System.Collections.Immutable;
 

src/Dependencies/CodeAnalysis.Debugging/DynamicLocalInfo.cs

@@ -2,7 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-#nullable disable
+#nullable enable
 
 using System.Collections.Immutable;
 

src/Dependencies/CodeAnalysis.Debugging/ImportTargetKind.cs

@@ -2,6 +2,8 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+#nullable enable
+
 namespace Microsoft.CodeAnalysis.Debugging
 {
     internal enum ImportTargetKind

src/Dependencies/CodeAnalysis.Debugging/Microsoft.CodeAnalysis.Debugging.Package.csproj

@@ -22,6 +22,7 @@
     <PackageReference Include="System.Collections.Immutable" />
     <PackageReference Include="System.Reflection.Metadata" />
     <PackageReference Include="System.ValueTuple" />
-    <ProjectReference Include="..\PooledObjects\Microsoft.CodeAnalysis.PooledObjects.Package.csproj" />
   </ItemGroup>
+  <Import Project="..\PooledObjects\Microsoft.CodeAnalysis.PooledObjects.projitems" Label="Shared" />
+  <Import Project="..\Contracts\Microsoft.CodeAnalysis.Contracts.projitems" Label="Shared" />
 </Project>

src/Dependencies/CodeAnalysis.Debugging/PortableCustomDebugInfoKinds.cs

@@ -2,6 +2,8 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+#nullable enable
+
 using System;
 
 namespace Microsoft.CodeAnalysis.Debugging

src/Dependencies/CodeAnalysis.Debugging/StateMachineHoistedLocalScope.cs

@@ -2,7 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-#nullable disable
+#nullable enable
 
 using System.Diagnostics;
 

src/Dependencies/CodeAnalysis.Debugging/TupleElementNamesInfo.cs

@@ -2,7 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-#nullable disable
+#nullable enable
 
 using System.Collections.Immutable;
 using System.Diagnostics;
@@ -11,13 +11,13 @@ namespace Microsoft.CodeAnalysis.Debugging
 {
     internal readonly struct TupleElementNamesInfo
     {
-        internal readonly ImmutableArray<string> ElementNames;
+        internal readonly ImmutableArray<string?> ElementNames;
         internal readonly int SlotIndex; // Locals only
         internal readonly string LocalName;
         internal readonly int ScopeStart; // Constants only
         internal readonly int ScopeEnd; // Constants only
 
-        internal TupleElementNamesInfo(ImmutableArray<string> elementNames, int slotIndex, string localName, int scopeStart, int scopeEnd)
+        internal TupleElementNamesInfo(ImmutableArray<string?> elementNames, int slotIndex, string localName, int scopeStart, int scopeEnd)
         {
             Debug.Assert(!elementNames.IsDefault);
 

src/Dependencies/CodeAnalysis.Debugging/VBImportScopeKind.cs

@@ -2,6 +2,8 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+#nullable enable
+
 namespace Microsoft.CodeAnalysis.Debugging
 {
     internal enum VBImportScopeKind

src/Dependencies/Collections/Extensions/ICollectionExtensions.cs

@@ -2,6 +2,8 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+#nullable enable
+
 using System;
 using System.Collections.Generic;
 using System.Collections.Immutable;

src/Dependencies/Collections/Extensions/IEnumerableExtensions.cs

@@ -2,6 +2,8 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+#nullable enable
+
 using System;
 using System.Collections;
 using System.Collections.Generic;

src/Dependencies/Collections/Extensions/ImmutableArrayExtensions.cs

@@ -2,6 +2,8 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+#nullable enable
+
 using System;
 using System.Collections.Generic;
 using System.Collections.Immutable;

src/Dependencies/Collections/Internal/ArraySortHelper.cs

@@ -2,6 +2,8 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+#nullable enable
+
 // NOTE: This code is derived from an implementation originally in dotnet/runtime:
 // https://github.com/dotnet/runtime/blob/v8.0.3/src/libraries/System.Private.CoreLib/src/System/Collections/Generic/ArraySortHelper.cs
 //

src/Dependencies/Collections/Internal/BitHelper.cs

@@ -2,6 +2,8 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+#nullable enable
+
 // NOTE: This code is derived from an implementation originally in dotnet/runtime:
 // https://github.com/dotnet/runtime/blob/v8.0.3/src/libraries/Common/src/System/Collections/Generic/BitHelper.cs
 //

src/Dependencies/Collections/Internal/HashHelpers.cs

@@ -2,6 +2,8 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+#nullable enable
+
 // NOTE: This code is derived from an implementation originally in dotnet/runtime:
 // https://github.com/dotnet/runtime/blob/v8.0.3/src/libraries/System.Private.CoreLib/src/System/Collections/HashHelpers.cs
 //

src/Dependencies/Collections/Internal/ICollectionCalls.cs

@@ -2,6 +2,8 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+#nullable enable
+
 using System;
 using System.Collections;
 

src/Dependencies/Collections/Internal/ICollectionCalls`1.cs

@@ -2,6 +2,8 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+#nullable enable
+
 using System.Collections.Generic;
 
 namespace Microsoft.CodeAnalysis.Collections.Internal

src/Dependencies/Collections/Internal/ICollectionDebugView`1.cs

@@ -2,6 +2,8 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+#nullable enable
+
 // NOTE: This code is derived from an implementation originally in dotnet/runtime:
 // https://github.com/dotnet/runtime/blob/v8.0.3/src/libraries/System.Private.CoreLib/src/System/Collections/Generic/ICollectionDebugView.cs
 //

src/Dependencies/Collections/Internal/IDictionaryCalls.cs

@@ -2,6 +2,8 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+#nullable enable
+
 using System;
 using System.Collections;
 

src/Dependencies/Collections/Internal/IDictionaryDebugView`2.cs

@@ -2,6 +2,8 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+#nullable enable
+
 // NOTE: This code is derived from an implementation originally in dotnet/runtime:
 // https://github.com/dotnet/runtime/blob/v8.0.3/src/libraries/System.Private.CoreLib/src/System/Collections/Generic/IDictionaryDebugView.cs
 //

src/Dependencies/Collections/Internal/IEnumerableCalls.cs

@@ -2,6 +2,8 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+#nullable enable
+
 using System.Collections;
 
 namespace Microsoft.CodeAnalysis.Collections.Internal

src/Dependencies/Collections/Internal/IEnumerableCalls`1.cs

@@ -2,6 +2,8 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+#nullable enable
+
 using System.Collections.Generic;
 
 namespace Microsoft.CodeAnalysis.Collections.Internal

src/Dependencies/Collections/Internal/IListCalls.cs

@@ -2,6 +2,8 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+#nullable enable
+
 using System.Collections;
 
 namespace Microsoft.CodeAnalysis.Collections.Internal

src/Dependencies/Collections/Internal/InsertionBehavior.cs

@@ -2,6 +2,8 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+#nullable enable
+
 // NOTE: This code is derived from an implementation originally in dotnet/runtime:
 // https://github.com/dotnet/runtime/blob/v8.0.3/src/libraries/System.Private.CoreLib/src/System/Collections/Generic/InsertionBehavior.cs
 //

src/Dependencies/Collections/Internal/RoslynUnsafe.cs

@@ -2,6 +2,8 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+#nullable enable
+
 using System.Runtime.CompilerServices;
 
 namespace Microsoft.CodeAnalysis.Collections.Internal

src/Dependencies/Collections/Internal/SegmentedArrayHelper.cs

@@ -2,6 +2,8 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+#nullable enable
+
 using System;
 using System.Diagnostics;
 using System.Runtime.CompilerServices;

src/Dependencies/Collections/Internal/SegmentedArraySegment`1.cs

@@ -2,6 +2,8 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+#nullable enable
+
 namespace Microsoft.CodeAnalysis.Collections.Internal
 {
     internal readonly struct SegmentedArraySegment<T>

src/Dependencies/Collections/Internal/SegmentedHashSetEqualityComparer`1.cs

@@ -2,6 +2,8 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+#nullable enable
+
 // NOTE: This code is derived from an implementation originally in dotnet/runtime:
 // https://github.com/dotnet/runtime/blob/v8.0.3/src/libraries/System.Private.CoreLib/src/System/Collections/Generic/HashSetEqualityComparer.cs
 //