Unify command handler code for 'go to base/impl' and 'find refs' #78750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
CyrusNajmabadi
commented
May 29, 2025
| listenerProvider.GetListener(FeatureAttribute.FindReferences), | ||
| globalOptions) | ||
| { | ||
| private readonly IStreamingFindUsagesPresenter _streamingPresenter; |
Member
Author
There was a problem hiding this comment.
redundant with teh code in AbstractGoOrFindCommandHandler.
CyrusNajmabadi
commented
May 29, 2025
| public string? InformationalMessage; | ||
| public string? SearchTitle; | ||
| public ImmutableArray<DefinitionItem>.Builder Definitions = ImmutableArray.CreateBuilder<DefinitionItem>(); | ||
| public ImmutableArray<SourceReferenceItem>.Builder References = ImmutableArray.CreateBuilder<SourceReferenceItem>(); |
Member
Author
There was a problem hiding this comment.
needed as technically FAR is handed the buffered progress guy and may start adding references to it before we swap it out to use the real FAR window.
CyrusNajmabadi
commented
May 29, 2025
| /// this source. | ||
| /// </remarks> | ||
| private CancellationTokenSource _cancellationTokenSource = new(); | ||
| private readonly CancellationSeries _cancellationSeries = new(threadingContext.DisposalToken); |
Member
Author
There was a problem hiding this comment.
simpler as a CancellationServies (and this code was written before we had that type).
CyrusNajmabadi
commented
May 29, 2025
| private Func<CancellationToken, Task>? _delayHook; | ||
|
|
||
| public abstract string DisplayName { get; } | ||
| protected abstract string ScopeDescription { get; } |
JoeRobich
reviewed
May 29, 2025
| } | ||
|
|
||
| return Task.Delay(TaggerDelay.OnIdle.ComputeTimeDelay(), cancellationToken); | ||
| // If we want to navigate to a single result if it is found quickly, then delay showing the find-refs winfor |
Member
There was a problem hiding this comment.
Suggested change
| // If we want to navigate to a single result if it is found quickly, then delay showing the find-refs winfor | |
| // If we want to navigate to a single result if it is found quickly, then delay showing the find-refs window |
Member
Author
There was a problem hiding this comment.
can fix in followup :)
JoeRobich
approved these changes
May 29, 2025
This was referenced Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the work to get us off progression. I want to build a unified service for handling these 3 commands. So they can be hooked up into solution explorer symbols trivially, with unified behavior.