Skip to content

Conversation

@DoctorKrolic
Copy link
Contributor

Fixes: #78510

I decided to modify and use CreateWithoutClone because:

  1. It was already used in lazy initialization of the syntax tree
  2. At the point where we assign a tree we have just created a red node and we fully own it. I don't see a reason to clone that node then

@DoctorKrolic DoctorKrolic requested review from a team as code owners June 2, 2025 16:03
@dotnet-policy-service dotnet-policy-service bot added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Jun 2, 2025
@DoctorKrolic DoctorKrolic requested a review from 333fred June 4, 2025 08:27
@DoctorKrolic
Copy link
Contributor Author

@333fred PTAL

Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dotnet/roslyn-compiler for a second review

@DoctorKrolic
Copy link
Contributor Author

Can I have a second review here please?

@RikkiGibson RikkiGibson self-assigned this Jun 16, 2025
Copy link
Member

@RikkiGibson RikkiGibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just had some minor comments.

@DoctorKrolic DoctorKrolic requested a review from RikkiGibson June 17, 2025 17:50
@DoctorKrolic DoctorKrolic requested a review from AlekseyTs June 19, 2025 16:41
@DoctorKrolic
Copy link
Contributor Author

@RikkiGibson @AlekseyTs PTAL

@333fred 333fred merged commit c8b5f30 into dotnet:main Jun 24, 2025
28 checks passed
@333fred
Copy link
Member

333fred commented Jun 24, 2025

Thanks @DoctorKrolic!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SyntaxFactory.ParseCompilationUnit drops parse options

4 participants