Move to .NET 10 Preview 5

eng/targets/Settings.props

@@ -15,7 +15,7 @@
     <NoWarn>$(NoWarn);VSIXCompatibility1001</NoWarn>
 
     <!-- TODO: https://github.com/dotnet/roslyn/issues/71667 -->
-    <NoWarn>$(NoWarn);NU1507</NoWarn>
+    <NoWarn>$(NoWarn);NU1507;NU1510</NoWarn>
 
     <CommonExtensionInstallationRoot>CommonExtensions</CommonExtensionInstallationRoot>
     <LanguageServicesExtensionInstallationFolder>Microsoft\VBCSharp\LanguageServices</LanguageServicesExtensionInstallationFolder>

global.json

@@ -1,13 +1,13 @@
 {
   "sdk": {
-    "version": "9.0.106",
+    "version": "10.0.100-preview.5.25277.114",
     "allowPrerelease": false,
     "rollForward": "patch"
   },
   "tools": {
-    "dotnet": "9.0.106",
+    "dotnet": "10.0.100-preview.5.25277.114",
     "vs": {
-      "version": "17.8.0"
+      "version": "17.14.0"
     },
     "vswhere": "3.1.7"
   },

src/Analyzers/Core/Analyzers/Helpers/HashCodeAnalyzer/HashCodeAnalyzer.cs

@@ -16,17 +16,15 @@ namespace Microsoft.CodeAnalysis.Shared.Utilities;
 /// </summary>
 internal readonly partial struct HashCodeAnalyzer
 {
-    private readonly Compilation _compilation;
     private readonly IMethodSymbol _objectGetHashCodeMethod;
     private readonly INamedTypeSymbol? _equalityComparerType;
 
     public readonly INamedTypeSymbol SystemHashCodeType;
 
     private HashCodeAnalyzer(
-        Compilation compilation, IMethodSymbol objectGetHashCodeMethod,
+        IMethodSymbol objectGetHashCodeMethod,
         INamedTypeSymbol? equalityComparerType, INamedTypeSymbol systemHashCodeType)
     {
-        _compilation = compilation;
         _objectGetHashCodeMethod = objectGetHashCodeMethod;
         _equalityComparerType = equalityComparerType;
         SystemHashCodeType = systemHashCodeType;
@@ -47,7 +45,7 @@ public static bool TryGetAnalyzer(Compilation compilation, [NotNullWhen(true)] o
         if (systemHashCodeType == null)
             return false;
 
-        analyzer = new HashCodeAnalyzer(compilation, objectGetHashCodeMethod, equalityComparerType, systemHashCodeType);
+        analyzer = new HashCodeAnalyzer(objectGetHashCodeMethod, equalityComparerType, systemHashCodeType);
         return true;
     }
 

src/Compilers/.editorconfig

@@ -12,6 +12,9 @@ dotnet_diagnostic.RS0100.severity = none
 # RS0102: Braces must not have blank lines between them
 dotnet_diagnostic.RS0102.severity = none
 
+# IDE0051: Unused member
+dotnet_diagnostic.IDE0051.severity = none
+
 # IDE0170: Prefer extended property pattern
 dotnet_diagnostic.IDE0170.severity = suggestion
 

src/Compilers/CSharp/Portable/Parser/LanguageParser_Patterns.cs

@@ -47,7 +47,7 @@ when ConvertExpressionToType(expr, out var leftType):
                 default:
                     type = null;
                     return false;
-            };
+            }
         }
 
         private PatternSyntax ParsePattern(Precedence precedence, bool afterIs = false, bool inSwitchArmPattern = false)

src/Compilers/CSharp/Portable/Parser/Lexer_RawStringLiteral.cs

@@ -117,7 +117,7 @@ private void ScanRawStringLiteral(ref TokenInfo info, bool inDirective)
 
                     default:
                         throw ExceptionUtilities.UnexpectedValue(info.Kind);
-                };
+                }
             }
 
             info.Text = TextWindow.GetText(intern: true);

src/Compilers/CSharp/Test/Emit/CodeGen/CodeGenOverridingAndHiding.cs

@@ -4126,7 +4126,7 @@ static void Main()
                 if (isFromMetadata)
                 {
                     VerifyParamArrayAttribute(parameterB);
-                };
+                }
             };
 
             var verifier = CompileAndVerify(source, symbolValidator: validator(true), sourceSymbolValidator: validator(false), expectedOutput: @"System.Int32[]");

src/Compilers/CSharp/Test/Emit/CodeGen/WinMdDelegateTests.cs

@@ -41,7 +41,7 @@ public void SimpleDelegateMembersTest(string ob, string cb)
                         GetMember<NamedTypeSymbol>("voidDelegate").GetMembers().ToArray();
 
                     AssertEx.SetEqual(actualMembers.Select(s => s.Name), expectedMembers);
-                };
+                }
             };
 
             VerifyType verify = (winmd, expected) =>

src/Compilers/CSharp/Test/Emit3/Attributes/AttributeTests_IsByRefLike.cs

@@ -683,7 +683,7 @@ void validate(ModuleSymbol module)
                     AssertDeclaresType(peModule, WellKnownType.System_Runtime_CompilerServices_IsByRefLikeAttribute, Accessibility.Public);
                     AssertHasCompilerFeatureRequired(includeCompilerFeatureRequired, peType, peModule, new MetadataDecoder(peModule));
                 }
-            };
+            }
 
             CompileAndVerify(new[] { text, GetCompilerFeatureRequiredAttributeText(includeCompilerFeatureRequired) }, verify: Verification.Passes, symbolValidator: validate, sourceSymbolValidator: validate);
         }

src/Compilers/CSharp/Test/Emit3/Attributes/AttributeTests_WellKnownAttributes.cs

@@ -5752,7 +5752,7 @@ void metadataValidator(ModuleSymbol module)
 
                 Assert.Equal(new[] { "CompilerGeneratedAttribute" }, GetAttributeNames(method.GetAttributes()));
                 Assert.True(method.RequiresSecurityObject);
-            };
+            }
 
             var verifier = CompileAndVerify(
                 source,

src/Compilers/CSharp/Test/Emit3/OverloadResolutionPriorityTests.cs

@@ -69,7 +69,7 @@ static void validate(ModuleSymbol module)
                     Assert.Equal(0, m.OverloadResolutionPriority);
                 }
             }
-        };
+        }
     }
 
     [Theory, CombinatorialData]

src/Compilers/Core/Portable/EmbeddedText.cs

@@ -370,7 +370,7 @@ public override void WriteByte(byte value)
                 base.WriteByte(value);
 
                 // same rationale for checked arithmetic as above.
-                checked { BytesWritten++; };
+                checked { BytesWritten++; }
             }
 
             public override Task WriteAsync(byte[] buffer, int offset, int count, CancellationToken cancellationToken)

src/Compilers/Core/Portable/MetadataReader/PEModule.cs

@@ -2338,19 +2338,6 @@ private static bool CrackBoolAndStringInAttributeValue(out BoolAndStringData val
             return false;
         }
 
-        private static bool CrackBoolAndBoolInAttributeValue(out (bool, bool) value, ref BlobReader sig)
-        {
-            if (CrackBooleanInAttributeValue(out bool item1, ref sig) &&
-                CrackBooleanInAttributeValue(out bool item2, ref sig))
-            {
-                value = (item1, item2);
-                return true;
-            }
-
-            value = default;
-            return false;
-        }
-
         private static bool CrackBooleanInAttributeValue(out bool value, ref BlobReader sig)
         {
             if (sig.RemainingBytes >= 1)

src/EditorFeatures/CSharp/AutomaticCompletion/AutomaticLineEnderCommandHandler_Helpers.cs

@@ -835,9 +835,6 @@ private static bool ShouldRemoveBraceForEventDeclaration(EventDeclarationSyntax
 
     #region AddBrace
 
-    private static AccessorListSyntax GetAccessorListNode(SyntaxFormattingOptions formattingOptions)
-        => AccessorList().WithOpenBraceToken(GetOpenBrace(formattingOptions)).WithCloseBraceToken(GetCloseBrace(formattingOptions));
-
     private static InitializerExpressionSyntax GetInitializerExpressionNode(SyntaxFormattingOptions formattingOptions)
         => InitializerExpression(SyntaxKind.ObjectInitializerExpression)
             .WithOpenBraceToken(GetOpenBrace(formattingOptions));

src/EditorFeatures/CSharp/ConvertNamespace/ConvertNamespaceCommandHandler.cs

@@ -40,8 +40,7 @@ internal sealed class ConvertNamespaceCommandHandler(
     ITextUndoHistoryRegistry textUndoHistoryRegistry,
     IEditorOperationsFactoryService editorOperationsFactoryService,
     EditorOptionsService editorOptionsService,
-    IGlobalOptionService globalOptions,
-    IIndentationManagerService indentationManager) : IChainedCommandHandler<TypeCharCommandArgs>
+    IGlobalOptionService globalOptions) : IChainedCommandHandler<TypeCharCommandArgs>
 {
     /// <summary>
     /// Option setting 'use file scoped'.  That way we can call into the helpers
@@ -54,7 +53,6 @@ internal sealed class ConvertNamespaceCommandHandler(
     private readonly ITextUndoHistoryRegistry _textUndoHistoryRegistry = textUndoHistoryRegistry;
     private readonly IEditorOperationsFactoryService _editorOperationsFactoryService = editorOperationsFactoryService;
     private readonly EditorOptionsService _editorOptionsService = editorOptionsService;
-    private readonly IIndentationManagerService _indentationManager = indentationManager;
     private readonly IGlobalOptionService _globalOptions = globalOptions;
 
     public CommandState GetCommandState(TypeCharCommandArgs args, Func<CommandState> nextCommandHandler)

src/EditorFeatures/CSharp/StringCopyPaste/StringCopyPasteCommandHandler.cs

@@ -55,19 +55,15 @@ internal sealed partial class StringCopyPasteCommandHandler(
     IEditorOperationsFactoryService editorOperationsFactoryService,
     IGlobalOptionService globalOptions,
     ITextBufferFactoryService2 textBufferFactoryService,
-    EditorOptionsService editorOptionsService,
-    IIndentationManagerService indentationManager) :
+    EditorOptionsService editorOptionsService) :
     IChainedCommandHandler<CutCommandArgs>,
     IChainedCommandHandler<CopyCommandArgs>,
     IChainedCommandHandler<PasteCommandArgs>
 {
-    private const string CopyId = "RoslynStringCopyPasteId";
-
     private readonly IThreadingContext _threadingContext = threadingContext;
     private readonly ITextUndoHistoryRegistry _undoHistoryRegistry = undoHistoryRegistry;
     private readonly IEditorOperationsFactoryService _editorOperationsFactoryService = editorOperationsFactoryService;
     private readonly EditorOptionsService _editorOptionsService = editorOptionsService;
-    private readonly IIndentationManagerService _indentationManager = indentationManager;
     private readonly IGlobalOptionService _globalOptions = globalOptions;
     private readonly ITextBufferFactoryService2 _textBufferFactoryService = textBufferFactoryService;
 

src/EditorFeatures/Core/Editor/IContainedDocument.cs

@@ -10,5 +10,5 @@ namespace Microsoft.CodeAnalysis.Editor;
 
 internal interface IContainedDocument
 {
-    public ITextSnapshot ApplyChanges(IEnumerable<TextChange> changes);
+    ITextSnapshot ApplyChanges(IEnumerable<TextChange> changes);
 }

src/EditorFeatures/Core/ExternalAccess/VSTypeScript/Api/AbstactVSTypeScriptLspServiceFactory.cs

@@ -5,6 +5,7 @@
 using Microsoft.CodeAnalysis.LanguageServer;
 
 namespace Microsoft.CodeAnalysis.ExternalAccess.VSTypeScript.Api;
+
 internal abstract class AbstractVSTypeScriptRequestHandlerFactory : ILspServiceFactory
 {
     public ILspService CreateILspService(LspServices lspServices, WellKnownLspServerKinds serverKind)

src/EditorFeatures/Core/InlineRename/InlineRenameService.cs

@@ -35,14 +35,12 @@ internal sealed class InlineRenameService(
     ITextBufferCloneService textBufferCloneService,
     IFeatureServiceFactory featureServiceFactory,
     IGlobalOptionService globalOptions,
-    [ImportMany] IEnumerable<IRefactorNotifyService> refactorNotifyServices,
     IAsynchronousOperationListenerProvider listenerProvider) : IInlineRenameService
 {
     private readonly IThreadingContext _threadingContext = threadingContext;
     private readonly IUIThreadOperationExecutor _uiThreadOperationExecutor = uiThreadOperationExecutor;
     private readonly ITextBufferAssociatedViewService _textBufferAssociatedViewService = textBufferAssociatedViewService;
     private readonly IAsynchronousOperationListener _asyncListener = listenerProvider.GetListener(FeatureAttribute.Rename);
-    private readonly IEnumerable<IRefactorNotifyService> _refactorNotifyServices = refactorNotifyServices;
     private readonly ITextBufferFactoryService _textBufferFactoryService = textBufferFactoryService;
     private readonly ITextBufferCloneService _textBufferCloneService = textBufferCloneService;
     private readonly IFeatureServiceFactory _featureServiceFactory = featureServiceFactory;
@@ -114,7 +112,6 @@ public async Task<InlineRenameSessionInfo> StartInlineSessionAsync(
             _textBufferFactoryService,
             _textBufferCloneService,
             _featureServiceFactory,
-            _refactorNotifyServices,
             _asyncListener);
 
         return new InlineRenameSessionInfo(ActiveSession);

src/EditorFeatures/Core/InlineRename/InlineRenameSession.cs

@@ -45,7 +45,6 @@ internal sealed partial class InlineRenameSession : IInlineRenameSession, IFeatu
 
     private readonly IFeatureService _featureService;
     private readonly IFeatureDisableToken _completionDisabledToken;
-    private readonly IEnumerable<IRefactorNotifyService> _refactorNotifyServices;
     private readonly IAsynchronousOperationListener _asyncListener;
     private readonly Solution _baseSolution;
     private readonly ITextView _triggerView;
@@ -146,7 +145,6 @@ public InlineRenameSession(
         ITextBufferFactoryService textBufferFactoryService,
         ITextBufferCloneService textBufferCloneService,
         IFeatureServiceFactory featureServiceFactory,
-        IEnumerable<IRefactorNotifyService> refactorNotifyServices,
         IAsynchronousOperationListener asyncListener)
     {
         // This should always be touching a symbol since we verified that upon invocation
@@ -177,7 +175,6 @@ public InlineRenameSession(
         _completionDisabledToken = _featureService.Disable(PredefinedEditorFeatureNames.Completion, this);
         RenameService = renameService;
         _uiThreadOperationExecutor = uiThreadOperationExecutor;
-        _refactorNotifyServices = refactorNotifyServices;
         _asyncListener = asyncListener;
         _triggerView = textBufferAssociatedViewService.GetAssociatedTextViews(triggerSpan.Snapshot.TextBuffer).FirstOrDefault(v => v.HasAggregateFocus) ??
             textBufferAssociatedViewService.GetAssociatedTextViews(triggerSpan.Snapshot.TextBuffer).First();

src/EditorFeatures/Core/InlineRename/UI/IInlineRenameColorUpdater.cs

@@ -9,5 +9,5 @@ internal interface IInlineRenameColorUpdater
     /// <summary>
     /// Implemented by a host to set the properties on <see cref="InlineRenameColors"/>.
     /// </summary>
-    public void UpdateColors();
+    void UpdateColors();
 }

src/EditorFeatures/Core/InlineRename/UI/SmartRename/SmartRenameViewModel.cs

@@ -45,7 +45,6 @@ internal sealed partial class SmartRenameViewModel : INotifyPropertyChanged, IDi
     /// </summary>
     private CancellationTokenSource _cancellationTokenSource = new();
     private bool _isDisposed;
-    private TimeSpan AutomaticFetchDelay => _smartRenameSession.AutomaticFetchDelay;
     private TimeSpan _semanticContextDelay;
     private bool _semanticContextError;
     private bool _semanticContextUsed;
@@ -67,7 +66,7 @@ internal sealed partial class SmartRenameViewModel : INotifyPropertyChanged, IDi
 
     /// <summary>
     /// Indicates whether a request to get suggestions is in progress.
-    /// The request to get suggestions is comprised of initial short delay, <see cref="AutomaticFetchDelay"/>
+    /// The request to get suggestions is comprised of initial short delay, see AutomaticFetchDelay
     /// and call to <see cref="ISmartRenameSessionWrapper.GetSuggestionsAsync(ImmutableDictionary{string, ImmutableArray{ValueTuple{string, string}}}, CancellationToken)"/>.
     /// When <c>true</c>, the UI shows the progress bar, and prevents <see cref="FetchSuggestions(bool)"/> from making parallel request.
     /// </summary>
@@ -196,7 +195,7 @@ private void FetchSuggestions(bool isAutomaticOnInitialization)
 
     /// <summary>
     /// The request for rename suggestions. It's made of three parts:
-    /// 1. Short delay of duration <see cref="AutomaticFetchDelay"/>.
+    /// 1. Short delay of duration AutomaticFetchDelay.
     /// 2. Get definition and references if <see cref="IsUsingSemanticContext"/> is set.
     /// 3. Call to <see cref="ISmartRenameSessionWrapper.GetSuggestionsAsync(ImmutableDictionary{string, ImmutableArray{ValueTuple{string, string}}}, CancellationToken)"/>.
     /// </summary>

src/EditorFeatures/Core/NavigableSymbols/NavigableSymbolService.cs

@@ -21,18 +21,15 @@ internal sealed partial class NavigableSymbolService : INavigableSymbolSourcePro
 {
     private static readonly object s_key = new();
 
-    private readonly IUIThreadOperationExecutor _uiThreadOperationExecutor;
     private readonly IThreadingContext _threadingContext;
     private readonly IAsynchronousOperationListener _listener;
 
     [ImportingConstructor]
     [SuppressMessage("RoslynDiagnosticsReliability", "RS0033:Importing constructor should be [Obsolete]", Justification = "Used in test code: https://github.com/dotnet/roslyn/issues/42814")]
     public NavigableSymbolService(
-        IUIThreadOperationExecutor uiThreadOperationExecutor,
         IThreadingContext threadingContext,
         IAsynchronousOperationListenerProvider listenerProvider)
     {
-        _uiThreadOperationExecutor = uiThreadOperationExecutor;
         _threadingContext = threadingContext;
         _listener = listenerProvider.GetListener(FeatureAttribute.NavigableSymbols);
     }

src/EditorFeatures/Core/Preview/IDifferenceViewerPreview.cs

@@ -10,5 +10,5 @@ namespace Microsoft.CodeAnalysis.Editor.Implementation.Preview;
 internal interface IDifferenceViewerPreview<TDifferenceViewer> : IDisposable
     where TDifferenceViewer : IDifferenceViewer
 {
-    public TDifferenceViewer Viewer { get; }
+    TDifferenceViewer Viewer { get; }
 }

src/EditorFeatures/Core/SplitComment/SplitCommentCommandHandler.cs

@@ -33,13 +33,11 @@ internal sealed class SplitCommentCommandHandler(
     ITextUndoHistoryRegistry undoHistoryRegistry,
     IEditorOperationsFactoryService editorOperationsFactoryService,
     EditorOptionsService editorOptionsService,
-    IIndentationManagerService indentationManager,
     IGlobalOptionService globalOptions) : ICommandHandler<ReturnKeyCommandArgs>
 {
     private readonly ITextUndoHistoryRegistry _undoHistoryRegistry = undoHistoryRegistry;
     private readonly IEditorOperationsFactoryService _editorOperationsFactoryService = editorOperationsFactoryService;
     private readonly EditorOptionsService _editorOptionsService = editorOptionsService;
-    private readonly IIndentationManagerService _indentationManager = indentationManager;
     private readonly IGlobalOptionService _globalOptions = globalOptions;
 
     public string DisplayName => EditorFeaturesResources.Split_comment;

src/EditorFeatures/Core/Tagging/AbstractAsynchronousTaggerProvider.TagSource.cs

@@ -55,11 +55,6 @@ private sealed partial class TagSource
 
         private readonly AbstractAsynchronousTaggerProvider<TTag> _dataSource;
 
-        /// <summary>
-        /// Information about what workspace the buffer we're tagging is associated with.
-        /// </summary>
-        private readonly WorkspaceRegistration _workspaceRegistration;
-
         /// <summary>
         /// Work queue that collects high priority requests to call TagsChanged with.
         /// </summary>
@@ -155,7 +150,7 @@ public TagSource(
             _nonFrozenComputationCancellationSeries = new(_disposalTokenSource.Token);
             _tagSpanSetPool = new ObjectPool<HashSet<TagSpan<TTag>>>(() => new HashSet<TagSpan<TTag>>(this), trimOnFree: false);
 
-            _workspaceRegistration = Workspace.GetWorkspaceRegistration(subjectBuffer.AsTextContainer());
+            Workspace.GetWorkspaceRegistration(subjectBuffer.AsTextContainer());
 
             // PERF: Use AsyncBatchingWorkQueue<_, VoidResult> instead of AsyncBatchingWorkQueue<_> because the latter
             // has an async state machine that rethrows a very common cancellation exception.

src/EditorFeatures/Test2/NavigableSymbols/NavigableSymbolsTest.vb

@@ -111,7 +111,7 @@ End Class"
         Private Shared Function ExtractSymbol(workspace As EditorTestWorkspace, position As Integer) As Task(Of INavigableSymbol)
             Dim threadingContext = workspace.ExportProvider.GetExportedValue(Of IThreadingContext)()
             Dim listenerProvider = workspace.ExportProvider.GetExportedValue(Of IAsynchronousOperationListenerProvider)
-            Dim service = New NavigableSymbolService(workspace.ExportProvider.GetExportedValue(Of IUIThreadOperationExecutor)(), threadingContext, listenerProvider)
+            Dim service = New NavigableSymbolService(threadingContext, listenerProvider)
             Dim view = workspace.Documents.First().GetTextView()
             Dim buffer = workspace.Documents.First().GetTextBuffer()
             Dim triggerSpan = New SnapshotSpan(buffer.CurrentSnapshot, New Span(position, 0))

src/EditorFeatures/TestUtilities/Threading/WpfTestRunner.cs

@@ -29,7 +29,9 @@ namespace Roslyn.Test.Utilities;
 /// </summary>
 public sealed class WpfTestRunner : XunitTestRunner
 {
+#pragma warning disable IDE0052 // Remove unread private members.  Can be used for debugging purposes.
     private static string s_wpfFactRequirementReason;
+#pragma warning restore IDE0052 // Remove unread private members
 
     public WpfTestSharedData SharedData { get; }
 

src/EditorFeatures/TestUtilities/Workspaces/EditorTestHostDocument.cs

@@ -198,13 +198,6 @@ public override void Open()
     public SourceTextContainer GetOpenTextContainer()
         => this.GetTextBuffer().AsTextContainer();
 
-    private void Update(string newText)
-    {
-        using var edit = this.GetTextBuffer().CreateEdit(EditOptions.DefaultMinimalChange, reiteratedVersionNumber: null, editTag: null);
-        edit.Replace(new Span(0, this.GetTextBuffer().CurrentSnapshot.Length), newText);
-        edit.Apply();
-    }
-
     internal void CloseTextView()
     {
         if (_textView != null && !_textView.IsClosed)