Initial support for compound assignment expression utilizing extension operators #78908
Conversation
AlekseyTs
added
Area-Compilers
Feature - Extension Everything
|
|
||
| foreach (var scope in new ExtensionScopes(this)) | ||
| { | ||
| extensionDeclarationsInSingleScope.Clear(); |
There was a problem hiding this comment.
I'd missed in previous PRs: just to confirm, we don't need to clear result too? #Resolved
There was a problem hiding this comment.
I'd missed in previous PRs: just to confirm, we don't need to clear
resulttoo?
BinaryOperatorExtensionOverloadResolutionInSingleScope clears it before repopulating.
| static void Main() | ||
| { | ||
| var s1 = new S1(); | ||
| s1 += s1; |
There was a problem hiding this comment.
Consider adding a test verifying IL so it can be seen what this lowers to. #Resolved
There was a problem hiding this comment.
Consider adding a test verifying IL so it can be seen what this lowers to.
I put the lowest priority on testing IL. There is nothing tricky about it apart from switching to implementation method. So, I think that IL verification, plus observing runtime behavior is sufficiently good. In addition at the bottom of this file there is a PROTOTYPE comment to increase coverage for runtime behavior.
I'll take care of this later. In reply to: 2964115516 Refers to: src/Compilers/CSharp/Test/Emit3/Semantics/ExtensionOperatorsTests.cs:16198 in 7d3d14c. [](commit_id = 7d3d14c, deletion_comment = False) |
3 participants
Relates to test plan #76130