Fix unnecessary dictionary allocations in semantic token classification #79105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
333fred
approved these changes
Jun 23, 2025
RikkiGibson
approved these changes
Jun 23, 2025
Member
There was a problem hiding this comment.
Whichever one we want to take between this and #79104 is fine with me
Member
|
Let's go with this one and hold the revert in reserve. |
Member
|
Force merging after clean builds to speed up insertion |
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Jun 23, 2025
* upstream/main: Fix unnecessary dictionary allocations in semantic token classification (dotnet#79105)
Member
|
oops, my bad 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.