Skip to content

Conversation

@CyrusNajmabadi
Copy link
Member

Backport #78376 to dev17.14

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner June 25, 2025 16:59
@CyrusNajmabadi CyrusNajmabadi requested a review from arunchndr June 25, 2025 17:04
@CyrusNajmabadi
Copy link
Member Author

@arunchndr ptal.

@arunchndr
Copy link
Contributor

@arunchndr ptal.

the NRE looks legit?

@CyrusNajmabadi
Copy link
Member Author

@arunchndr the crash is in navbars, which i'm not touching. I think it's possibly in the test code that is trying to hook up navbars. i.e.:

   at Microsoft.CodeAnalysis.UnitTests.ObjectExtensions.GetFieldValue(Object instance, String fieldName) in /_/src/Workspaces/CoreTestUtilities/ObjectExtensions.cs:line 49
   at Microsoft.CodeAnalysis.UnitTests.ObjectExtensions.GetFieldValue[FieldType](Object instance, String fieldName) in /_/src/Workspaces/CoreTestUtilities/ObjectExtensions.cs:line 58
   at Microsoft.VisualStudio.Extensibility.Testing.EditorInProcess.<GetNavigationBarComboBoxesAsync>d__39.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/EditorInProcess.cs:line 569

@JoeRobich
Copy link
Member

May be fixed by @jasonmalinowski's backport #79076

@dotnet dotnet deleted a comment from JoeRobich Jun 26, 2025
@dotnet dotnet deleted a comment from azure-pipelines bot Jun 26, 2025
@jasonmalinowski
Copy link
Member

Yep that was the issue I fixed.

@CyrusNajmabadi
Copy link
Member Author

@arunchndr this si green

@arunchndr arunchndr merged commit fd15dd5 into dotnet:release/dev17.14 Jun 26, 2025
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the backport78376 branch June 26, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants