Skip to content

Revert "Remove the 'intent' subsystem from roslyn (#79179)" #79198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025
Merged

Revert "Remove the 'intent' subsystem from roslyn (#79179)" #79198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
273 changes: 273 additions & 0 deletions src/EditorFeatures/CSharpTest/Intents/AddConstructorParameterIntentTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,273 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using System.Threading.Tasks;
using Microsoft.CodeAnalysis.CodeStyle;
using Microsoft.CodeAnalysis.Editor.UnitTests.CodeActions;
using Microsoft.CodeAnalysis.Features.Intents;
using Microsoft.CodeAnalysis.Test.Utilities;
using Xunit;

namespace Microsoft.CodeAnalysis.Editor.CSharp.UnitTests.Intents;

[UseExportProvider]
public sealed class AddConstructorParameterIntentTests : IntentTestsBase
{
[Fact]
public async Task AddConstructorParameterWithField()
{
var initialText =
"""
class C
{
private readonly int _someInt;{|priorSelection:|}

public C()
{
}
}
""";

var currentText =
"""
class C
{
private readonly int _someInt;

public C(int som)
{
}
}
""";
var expectedText =
"""
class C
{
private readonly int _someInt;

public C(int someInt)
{
_someInt = someInt;
}
}
""";

await VerifyExpectedTextAsync(WellKnownIntents.AddConstructorParameter, initialText, currentText, expectedText).ConfigureAwait(false);
}

[Fact]
public async Task AddConstructorParameterWithProperty()
{
var initialText =
"""
class C
{
public int SomeInt { get; }{|priorSelection:|}

public C()
{
}
}
""";
var currentText =
"""
class C
{
public int SomeInt { get; }

public C(int som)
{
}
}
""";
var expectedText =
"""
class C
{
public int SomeInt { get; }

public C(int someInt)
{
SomeInt = someInt;
}
}
""";

await VerifyExpectedTextAsync(WellKnownIntents.AddConstructorParameter, initialText, currentText, expectedText).ConfigureAwait(false);
}

[Fact]
public async Task AddMultipleConstructorParameters()
{
var initialText =
"""
class C
{
{|priorSelection:private readonly int _someInt;
private readonly string _someString;|}

public C()
{
}
}
""";
var currentText =
"""
class C
{
{|priorSelection:private readonly int _someInt;
private readonly string _someString;|}

public C(int som)
{
}
}
""";
var expectedText =
"""
class C
{
private readonly int _someInt;
private readonly string _someString;

public C(int someInt, string someString)
{
_someInt = someInt;
_someString = someString;
}
}
""";

await VerifyExpectedTextAsync(WellKnownIntents.AddConstructorParameter, initialText, currentText, expectedText).ConfigureAwait(false);
}

[Fact]
public async Task AddConstructorParameterOnlyAddsSelected()
{
var initialText =
"""
class C
{
private readonly int _someInt;{|priorSelection:|}
private readonly string _someString;

public C()
{
}
}
""";
var currentText =
"""
class C
{
private readonly int _someInt;{|priorSelection:|}
private readonly string _someString;

public C(int som)
{
}
}
""";
var expectedText =
"""
class C
{
private readonly int _someInt;
private readonly string _someString;

public C(int someInt)
{
_someInt = someInt;
}
}
""";

await VerifyExpectedTextAsync(WellKnownIntents.AddConstructorParameter, initialText, currentText, expectedText).ConfigureAwait(false);
}

[Fact]
public async Task AddConstructorParameterUsesCodeStyleOption()
{
var initialText =
"""
class C
{
private readonly int _someInt;{|priorSelection:|}

public C()
{
}
}
""";
var currentText =
"""
class C
{
private readonly int _someInt;{|priorSelection:|}

public C(int som)
{
}
}
""";
var expectedText =
"""
class C
{
private readonly int _someInt;

public C(int someInt)
{
this._someInt = someInt;
}
}
""";
await VerifyExpectedTextAsync(WellKnownIntents.AddConstructorParameter, initialText, currentText, expectedText,
options: new OptionsCollection(LanguageNames.CSharp)
{
{ CodeStyleOptions2.QualifyFieldAccess, true }
}).ConfigureAwait(false);
}

[Fact]
public async Task AddConstructorParameterUsesExistingAccessibility()
{
var initialText =
"""
class C
{
private readonly int _someInt;{|priorSelection:|}

protected C()
{
}
}
""";
var currentText =
"""
class C
{
private readonly int _someInt;{|priorSelection:|}

protected C(int som)
{
}
}
""";
var expectedText =
"""
class C
{
private readonly int _someInt;

protected C(int someInt)
{
_someInt = someInt;
}
}
""";

await VerifyExpectedTextAsync(WellKnownIntents.AddConstructorParameter, initialText, currentText, expectedText).ConfigureAwait(false);
}
}
Loading
Loading