Use ConfigureAwait(true) when in a blocking JTF run call

[CyrusNajmabadi]

Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2521664

[jasonmalinowski]

Perf tweak to use GetTextSynchronously could be a follow up.

[ToddGrun]

[CyrusNajmabadi]

Made the tweaks.

[CyrusNajmabadi]

Agreed. Made that change as well.

…

On Thu, Jul 17, 2025 at 5:23 PM Todd Grunke ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/VisualStudio/Core/Def/LanguageService/AbstractLanguageService`2.VsLanguageDebugInfo.cs <#79456 (comment)>: > - span = mappedSpan.Value; - - return new VsDebugName(breakpoint.LocationNameOpt, filePath!, span); + async ValueTask<IVsDebugName> CreateDebugNameAsync( + BreakpointResolutionResult breakpoint, CancellationToken cancellationToken) + { + // We're in a blocking jtf run. So CA(true) all calls to ensure we're coming bac + // and using the blocked thread whenever possible. + + var document = breakpoint.Document; + var filePath = _languageService.Workspace.GetFilePath(document.Id); + var text = await document.GetValueTextAsync(cancellationToken).ConfigureAwait(true); + var span = text.GetVsTextSpanForSpan(breakpoint.TextSpan); + // If we're inside an Venus code nugget, we need to map the span to the surface buffer. + // Otherwise, we'll just use the original span. + var mappedSpan = await span.MapSpanFromSecondaryBufferToPrimaryBufferAsync( MapSpanFromSecondaryBufferToPrimaryBufferAsync <http://example.com/codeflow?start=44&length=46> It looks like the only reason MapSpanFromSecondaryBufferToPrimaryBufferAsync is async is to ensure we're on the main thread. Should we just use a sync version of that method instead? — Reply to this email directly, view it on GitHub <#79456 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABC2MY2KVV432FPJB5VFLO33JA473AVCNFSM6AAAAACBZHHKHOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTAMZRGM4DINBXGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>