Get rid of legacy test methods. #79532
Conversation
|
|
||
| [Fact] | ||
| public Task Test1() | ||
| => TestInRegularAndScript1Async( |
There was a problem hiding this comment.
we had to have this '1' in the name to prevent ambiguity collisions. Now the duplicative members are gone. so the naming ludge isn't needed.
| @@ -405,32 +405,15 @@ protected async Task TestActionCountAsync( | |||
| } | |||
|
|
|||
| internal Task TestInRegularAndScriptAsync( | |||
There was a problem hiding this comment.
these (and other methods like these) were the core methods i wanted to remove. They're massive, and we often take them (with small tweaks) and put in other locations. Having these be trivial (input, expected, optional parameters) means getting rid of a bunch of overloads that confusing called each other (and often could do things like miss some parameter along the way).
|
@dotnet/roslyn-ide ptal |
| Assert.Equal(count, actions.Length); | ||
| } | ||
|
|
||
| internal Task TestInRegularAndScriptAsync( |
There was a problem hiding this comment.
Not sure what you're asking me.
There was a problem hiding this comment.
Diff shows the code as commented out, so I'm checking if you meant to delete it.
3 participants
Moves us down to a smaller and simpler set of testing overloads to maintain.
Note: there is likely more cleanup coming. The test harness has morphed so much, and there's lots of redundancy everywhere.