Modify LSP folding ranges to account for AutoCollapse #79551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VS editor uses VSFoldingRangeKind.Implementation to determine which regions need to be collapsed during it's CollapseToDefinitions implementation (https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_git/VSEditor?path=/src/Editor/VisualStudio/Impl/ViewAdapter/IOleCommandTarget.cs&version=GBmain&line=2454&lineEnd=2455&lineStartColumn=1&lineEndColumn=1&lineStyle=plain&_a=contents) This commit ensures that we set this flag when our BlockSpan.AutoCollapse flag is set (which indicates that it should be collapsed when Collapse to Definitions is invoked). https://github.com/dotnet/roslyn/blob/5f51f252332bd2bff80831c2c95f119aab9bb768/src/Features/Core/Portable/Structure/BlockSpan.cs#L64 Addresses the LSP C# equivalent of https://developercommunity.visualstudio.com/t/Blazor:-Ctrl--M-O-not-working-for-ra/10857833#T-ND10941241
dibarbet
approved these changes
Jul 23, 2025
davidwengier
approved these changes
Jul 23, 2025
Open
3 tasks
This was referenced Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VS editor uses VSFoldingRangeKind.Implementation to determine which regions need to be collapsed during it's CollapseToDefinitions implementation
This commit ensures that we set this flag when BlockSpan.AutoCollapse is set, indicating this block should be collapsed when Collapse to Definitions is invoked.
Addresses the C# LSP equivalent of this community ticket