Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
291 commits
Select commit Hold shift + click to select a range
df9c10a
Merge branch 'main' into useAutoPropWellKnownTypes
CyrusNajmabadi Jul 17, 2025
ac1740d
Merge branch 'main' into spanReadOnly
CyrusNajmabadi Jul 17, 2025
9d04d42
Merge branch 'main' into usePropTrailingTrivia
CyrusNajmabadi Jul 17, 2025
b7159b0
Merge branch 'main' into useAutoPropResolution
CyrusNajmabadi Jul 17, 2025
05aa085
Merge branch 'main' into indentTestArgs
CyrusNajmabadi Jul 17, 2025
abd8aba
Support interpolated string handlers in extension blocks (#78425)
333fred Jul 17, 2025
c458836
Fix loss of nullability attributes when getting the 'constructed redu…
CyrusNajmabadi Jul 17, 2025
cd1ee88
Add tracking issue for disabled assert (#79427)
333fred Jul 17, 2025
c2d43dd
Preserve comments when switching to auto props (#79420)
CyrusNajmabadi Jul 17, 2025
c85f4e4
Special case a few well-known immutable types in use-auto-prop (#79422)
CyrusNajmabadi Jul 17, 2025
f0f223d
Indent test arguments (#79403)
CyrusNajmabadi Jul 17, 2025
0fa8456
Change how trailing trivia is preserved in use-auto-prop (#79425)
CyrusNajmabadi Jul 17, 2025
e11f53e
Fix make-readonly with spans. (#79393)
CyrusNajmabadi Jul 17, 2025
05dd8e6
Fix code gen for some compound assignment scenarios involving extensi…
AlekseyTs Jul 17, 2025
1d8a729
Extensions: extension marker type name (#79308)
Jul 17, 2025
24ab192
Fix issue where we weren't properly preserving indentation when pasti…
CyrusNajmabadi Jul 17, 2025
4d2d314
Move to xunit.runner.visualstudio 3.1.3
JoeRobich Jul 17, 2025
06f095f
Update 'use auto property' to respect user options around `this.` for…
CyrusNajmabadi Jul 17, 2025
5db3521
Avoid eliding pointer-to-ref conversions (#79311)
jjonescz Jul 17, 2025
bf18293
Avoid reusing temps whose refs might be captured (#76009)
jjonescz Jul 17, 2025
1417783
[main] Update dependencies from dotnet/arcade (#79385)
dotnet-maestro[bot] Jul 17, 2025
53e743b
Move to xunit.runner.visualstudio 3.1.3 (#79434)
JoeRobich Jul 17, 2025
3e26030
Fixes rename attribute bug (#79418)
akhera99 Jul 17, 2025
e15133d
Adds EqualityComparer<T>.Create polyfill
tmat Jul 11, 2025
c2e6539
Revert compiler changes
tmat Jul 16, 2025
49e3b4c
Adds EqualityComparer<T>.Create polyfill (#79345)
tmat Jul 17, 2025
dcf2c47
Update dependencies from https://github.com/dotnet/arcade build 20250…
dotnet-maestro[bot] Jul 17, 2025
4fab744
Move to .NET 10p6 (#79438)
333fred Jul 17, 2025
37a47b7
Allow razor to use SolutionChecksumUpdater (#79373)
ToddGrun Jul 17, 2025
e72424d
Merge branch 'main' into darc-main-2096bf96-698f-497f-8bf3-8ba22cdf7bff
JoeRobich Jul 17, 2025
7f995b8
Remove dependency on ClassificationOptions and DefinitionItem from Se…
tmat Jul 17, 2025
32fa948
Update insertions for VS release changes
dibarbet Jul 17, 2025
36e32a7
Fix static extension method not showing up on enum type
CyrusNajmabadi Jul 17, 2025
76f8db4
Add workitem
CyrusNajmabadi Jul 17, 2025
a973839
cleanup
CyrusNajmabadi Jul 18, 2025
de36829
Use ConfigureAwait(true) when in a blocking JTF run call
CyrusNajmabadi Jul 18, 2025
70605ed
GetTextSynchronously
CyrusNajmabadi Jul 18, 2025
fe13914
Update src/VisualStudio/Core/Def/LanguageService/AbstractLanguageServ…
CyrusNajmabadi Jul 18, 2025
d6a1e94
Make synchronous
CyrusNajmabadi Jul 18, 2025
ca30655
Merge branch 'resolveNameCA' of https://github.com/CyrusNajmabadi/ros…
CyrusNajmabadi Jul 18, 2025
a08551e
Docs
CyrusNajmabadi Jul 18, 2025
8487180
Fix static extension method not showing up on enum type (#79454)
CyrusNajmabadi Jul 18, 2025
d903f6c
Allow Razor to create a formatting options, and send it to OOP
davidwengier Jul 18, 2025
a327c20
Use ConfigureAwait(true) when in a blocking JTF run call (#79456)
CyrusNajmabadi Jul 18, 2025
df031fe
Update dependencies from https://github.com/dotnet/arcade build 20250…
dotnet-maestro[bot] Jul 18, 2025
d26e727
Remove assumption about a tree shape that compound assignment produce…
AlekseyTs Jul 18, 2025
0e6493c
Skip GetProjectXml_FileBasedProgram_SdkTooOld_01 test
JoeRobich Jul 18, 2025
18633f1
Update insertions for VS release changes (#79453)
dibarbet Jul 18, 2025
6136b95
Skip GetProjectXml_FileBasedProgram_SdkTooOld_01 test (#79465)
JoeRobich Jul 18, 2025
ed4ca0d
Bump Microsoft.VisualStudio.Extensibility.Testing.Xunit to 0.1.796-beta
jasonmalinowski Jul 18, 2025
62daf28
Reduce path length of Roslyn ServiceHub Services folder (#79460)
ToddGrun Jul 18, 2025
178e419
Bump Microsoft.VisualStudio.Extensibility.Testing.Xunit to 0.1.796-be…
JoeRobich Jul 18, 2025
2322a30
downgrade SDK
JoeRobich Jul 18, 2025
c82daf2
Fix Typo
JoeRobich Jul 18, 2025
858c3a8
Simplify stale project handling (#79386)
tmat Jul 18, 2025
16926d9
Update System.Memory to prevent bootstrap failure
dibarbet Jul 18, 2025
757c336
Include dependencies of System.Memory in VSIX deployment project
dibarbet Jul 19, 2025
a5f99bd
remove unnecessary additional reference
dibarbet Jul 19, 2025
dcfd472
Update dependencies from https://github.com/dotnet/arcade build 20250…
dotnet-maestro[bot] Jul 19, 2025
5069c81
Update System.Memory to prevent bootstrap failure (#79475)
dibarbet Jul 19, 2025
147fd7c
Use new compiler API
DoctorKrolic Jul 19, 2025
c3b8200
Correctly change return type of partial definition part
DoctorKrolic Jul 19, 2025
dc2da5a
Feedback
DoctorKrolic Jul 19, 2025
934c2a1
Move RoslynParallel and ProducerConsumer to threading source package …
tmat Jul 19, 2025
a8d4395
Correctly change return type of partial method definition part when m…
CyrusNajmabadi Jul 19, 2025
e0b6852
Downgrade SDK
JoeRobich Jul 19, 2025
0f029e2
Allow Razor to create a formatting options, and send them to OOP (#79…
davidwengier Jul 21, 2025
300814b
Do not remove usings/imports in code-cleanup when file has syntax errors
CyrusNajmabadi Jul 21, 2025
e38b24d
Add testws
CyrusNajmabadi Jul 21, 2025
35ebb57
Find add-using results in SG docs
CyrusNajmabadi Jul 21, 2025
2e23a0d
Docs
CyrusNajmabadi Jul 21, 2025
0e8140c
Do not remove usings/imports in code-cleanup when file has syntax err…
CyrusNajmabadi Jul 21, 2025
d60983c
Do not place SuppressMessage attributes on an extension block
CyrusNajmabadi Jul 21, 2025
391e50f
remove asynchrony from service registration
CyrusNajmabadi Jul 21, 2025
9fb6896
Find add-using results in SG docs (#79490)
CyrusNajmabadi Jul 21, 2025
8978faa
Ignore all targets of MS.CA.Threading.Package in rebuild (#79495)
tmat Jul 21, 2025
bb456f4
Don't mark special compiler synthesized members as obsolete
CyrusNajmabadi Jul 21, 2025
1f2e90f
Add test
CyrusNajmabadi Jul 21, 2025
d8a78d8
Do not place SuppressMessage attributes on an extension block (#79492)
CyrusNajmabadi Jul 21, 2025
cf34acb
Use globs in .projitems for source packages (#79480)
tmat Jul 21, 2025
db9c99f
Fix name declaration completion in primary constructor parameters
CyrusNajmabadi Jul 21, 2025
95d0b54
nrt
CyrusNajmabadi Jul 21, 2025
073170b
nrt
CyrusNajmabadi Jul 21, 2025
bf511e3
Generate complogs on build failure (#79446)
333fred Jul 21, 2025
1b4f5d7
remove from pkgdefs
CyrusNajmabadi Jul 21, 2025
ca139f2
Extensions: fix issue with GetParameterOrExtensionParameter (#79402)
Jul 21, 2025
5abfd5e
Fix exception when requesting additional file diagnostics
dibarbet Jul 21, 2025
e55e7c1
Fix name declaration completion in primary constructor parameters (#7…
CyrusNajmabadi Jul 21, 2025
f7cd701
Don't mark special compiler synthesized members as obsolete (#79496)
CyrusNajmabadi Jul 21, 2025
0e686f3
Remove asynchrony from service registration (#79493)
CyrusNajmabadi Jul 21, 2025
a78e9de
Fix exception when requesting additional file diagnostics (#79501)
dibarbet Jul 21, 2025
72a0df3
[main] Update dependencies from dotnet/arcade (#79450)
JoeRobich Jul 21, 2025
afa9592
Do not do full cleanup when we are formatting a new document
jasonmalinowski Jul 22, 2025
f25ae8e
Extensions: add test for function type scenario (#79323)
Jul 22, 2025
794a194
Reenable analyzer that was disabled when we moved to .Net 10 Preview 5
CyrusNajmabadi Jul 22, 2025
d3f2156
Allow captured primary constructor parameters to be still used in bas…
CyrusNajmabadi Jul 22, 2025
23b7465
Simplify ancestor checks
CyrusNajmabadi Jul 22, 2025
7be4c96
Fix 'this' keyword not being recomended where allowed
CyrusNajmabadi Jul 22, 2025
a3b39e8
in progress
CyrusNajmabadi Jul 22, 2025
078829b
Fix 'switch' keyword recomendations after an expression
CyrusNajmabadi Jul 22, 2025
6d868d2
Fix escaping of enum members in completion
CyrusNajmabadi Jul 22, 2025
5804e6b
Suggest proper 'Async'-suffixed name for Task-returning symbols
CyrusNajmabadi Jul 22, 2025
a00cac2
Fix location of 'partial' modifier when generating new partial members
CyrusNajmabadi Jul 22, 2025
27b63ab
Update VMR orchestrator property (#79517)
mmitche Jul 22, 2025
ceb42af
Make attachdebugger flag work on non-Windows (#79499)
333fred Jul 22, 2025
07faf00
Reenable analyzer that was disabled when we moved to .Net 10 Preview …
CyrusNajmabadi Jul 22, 2025
bc6cf84
Suggest proper 'Async'-suffixed name for Task-returning symbols (#79518)
CyrusNajmabadi Jul 22, 2025
4e6c46b
Fix escaping of enum members in completion (#79516)
CyrusNajmabadi Jul 22, 2025
c765c39
Do not do full cleanup when we are formatting a new document (#79508)
jasonmalinowski Jul 22, 2025
f5f17a7
Fix 'switch' keyword recomendations after an expression (#79515)
CyrusNajmabadi Jul 22, 2025
e1bd1be
Downgrade System.Memory to make VS happy
dibarbet Jul 22, 2025
be70cf4
Allow captured primary constructor parameters to be still used in bas…
CyrusNajmabadi Jul 22, 2025
e85d47f
Fix auth issue in PR val builds
dibarbet Jul 22, 2025
5e104ee
Merge remote-tracking branch 'upstream/main' into thisInNameof
CyrusNajmabadi Jul 22, 2025
f8f433b
Fix
CyrusNajmabadi Jul 22, 2025
dfdacfd
Prevent auth issue in PR val builds (#79524)
dibarbet Jul 22, 2025
63bb7cb
Fix 'this' keyword not being recomended where allowed (#79514)
CyrusNajmabadi Jul 22, 2025
5eb1a8c
Downgrade System.Memory to make VS happy (#79523)
dibarbet Jul 22, 2025
764338f
Update Basic.Reference.Assemblies (#79525)
333fred Jul 23, 2025
b7112b3
Allow add using to work on Razor generated documents
davidwengier Jul 23, 2025
a4fd5b7
Simplify ancestor checks (#79513)
CyrusNajmabadi Jul 23, 2025
3c013a3
Allow add using to work on Razor generated documents (#79530)
davidwengier Jul 23, 2025
92afc3e
Improve compiler server/client logging (#79335)
jjonescz Jul 23, 2025
65f2d0c
Cleanup
CyrusNajmabadi Jul 23, 2025
577861c
Simplify
CyrusNajmabadi Jul 23, 2025
d36d299
Simplify
CyrusNajmabadi Jul 23, 2025
86b84f8
Simplify
CyrusNajmabadi Jul 23, 2025
a1de5ad
Add tests
CyrusNajmabadi Jul 23, 2025
875a30a
Add tests
CyrusNajmabadi Jul 23, 2025
822c140
Simplify
CyrusNajmabadi Jul 23, 2025
7c52a04
Simplify
CyrusNajmabadi Jul 23, 2025
cd3d94f
initial change
CyrusNajmabadi Jul 23, 2025
a167ea9
Renames
CyrusNajmabadi Jul 23, 2025
c57c742
Update tests
CyrusNajmabadi Jul 23, 2025
d6905ae
Update tests
CyrusNajmabadi Jul 23, 2025
7fa31e8
Update tests
CyrusNajmabadi Jul 23, 2025
0c291fe
Update tests
CyrusNajmabadi Jul 23, 2025
3aa2251
Update tests
CyrusNajmabadi Jul 23, 2025
31b5443
Update tests
CyrusNajmabadi Jul 23, 2025
29528b5
Update tests
CyrusNajmabadi Jul 23, 2025
f185305
Update tests
CyrusNajmabadi Jul 23, 2025
27a03a6
Update tests
CyrusNajmabadi Jul 23, 2025
872ef8f
Update tests
CyrusNajmabadi Jul 23, 2025
324f41a
Update tests
CyrusNajmabadi Jul 23, 2025
70d63a7
Update tests
CyrusNajmabadi Jul 23, 2025
7eb530f
Update tests
CyrusNajmabadi Jul 23, 2025
27425f7
Update tests
CyrusNajmabadi Jul 23, 2025
c3d56c8
Update tests
CyrusNajmabadi Jul 23, 2025
2cf674b
Update tests
CyrusNajmabadi Jul 23, 2025
6d28994
Update tests
CyrusNajmabadi Jul 23, 2025
a782d97
Update tests
CyrusNajmabadi Jul 23, 2025
186259d
Update tests
CyrusNajmabadi Jul 23, 2025
b554e68
Update tests
CyrusNajmabadi Jul 23, 2025
ecbfdb6
Update tests
CyrusNajmabadi Jul 23, 2025
d92f4c2
Update tests
CyrusNajmabadi Jul 23, 2025
cb8d294
Extensions: address or split remaining open issues directly associate…
Jul 23, 2025
f212f77
Update tests
CyrusNajmabadi Jul 23, 2025
095995d
Update tests
CyrusNajmabadi Jul 23, 2025
b1951d2
Update tests
CyrusNajmabadi Jul 23, 2025
9f4befb
Update tests
CyrusNajmabadi Jul 23, 2025
2533bd1
Update tests
CyrusNajmabadi Jul 23, 2025
92f8d5b
Update tests
CyrusNajmabadi Jul 23, 2025
5aa6ac0
Update tests
CyrusNajmabadi Jul 23, 2025
2ab2270
Update tests
CyrusNajmabadi Jul 23, 2025
0870c68
Update tests
CyrusNajmabadi Jul 23, 2025
c7cc0fa
Update tests
CyrusNajmabadi Jul 23, 2025
2668de4
Update tests
CyrusNajmabadi Jul 23, 2025
52bbc89
Update tests
CyrusNajmabadi Jul 23, 2025
1cba585
Update tests
CyrusNajmabadi Jul 23, 2025
e6b2b41
Update tests
CyrusNajmabadi Jul 23, 2025
3d58494
Update tests
CyrusNajmabadi Jul 23, 2025
cb96198
Update tests
CyrusNajmabadi Jul 23, 2025
6cab13a
Update tests
CyrusNajmabadi Jul 23, 2025
289f6df
Update tests
CyrusNajmabadi Jul 23, 2025
75a20ae
Update tests
CyrusNajmabadi Jul 23, 2025
19d4f52
Update tests
CyrusNajmabadi Jul 23, 2025
ed7716e
Update tests
CyrusNajmabadi Jul 23, 2025
ace7474
Update tests
CyrusNajmabadi Jul 23, 2025
8f90eb7
Update tests
CyrusNajmabadi Jul 23, 2025
d98c5c9
Update tests
CyrusNajmabadi Jul 23, 2025
c7ad018
Update tests
CyrusNajmabadi Jul 23, 2025
c3f3be1
Update tests
CyrusNajmabadi Jul 23, 2025
ab828ff
Update tests
CyrusNajmabadi Jul 23, 2025
79ce4c9
Update tests
CyrusNajmabadi Jul 23, 2025
2564640
Update tests
CyrusNajmabadi Jul 23, 2025
7e87f81
Update tests
CyrusNajmabadi Jul 23, 2025
d00e047
Update tests
CyrusNajmabadi Jul 23, 2025
afb1347
Update tests
CyrusNajmabadi Jul 23, 2025
3871b9d
Update tests
CyrusNajmabadi Jul 23, 2025
ec7d61c
Update tests
CyrusNajmabadi Jul 23, 2025
e3da384
Update tests
CyrusNajmabadi Jul 23, 2025
cb2db07
Update tests
CyrusNajmabadi Jul 23, 2025
a3e419e
Update tests
CyrusNajmabadi Jul 23, 2025
bba4450
Update tests
CyrusNajmabadi Jul 23, 2025
ff7f18d
Update tests
CyrusNajmabadi Jul 23, 2025
7fc502f
Update tests
CyrusNajmabadi Jul 23, 2025
09fb4d8
Update tests
CyrusNajmabadi Jul 23, 2025
fd756c8
Update tests
CyrusNajmabadi Jul 23, 2025
fa0d060
Update tests
CyrusNajmabadi Jul 23, 2025
b459d91
Update tests
CyrusNajmabadi Jul 23, 2025
e8bd575
Update tests
CyrusNajmabadi Jul 23, 2025
467a929
In progress
CyrusNajmabadi Jul 23, 2025
806f396
in progress
CyrusNajmabadi Jul 23, 2025
0253d50
in progress
CyrusNajmabadi Jul 23, 2025
78b3e3b
in progress
CyrusNajmabadi Jul 23, 2025
336a4c3
in progress
CyrusNajmabadi Jul 23, 2025
e55aab7
in progress
CyrusNajmabadi Jul 23, 2025
e5fdc55
in progress
CyrusNajmabadi Jul 23, 2025
528eaa2
in progress
CyrusNajmabadi Jul 23, 2025
a39c638
Cleanup split between lexer and sliding-text-window (#79205)
CyrusNajmabadi Jul 23, 2025
1d0ad29
Add docs
CyrusNajmabadi Jul 23, 2025
196c88a
Fix name qualification when moving a using alias outside of a file sc…
CyrusNajmabadi Jul 23, 2025
fc0fa76
Fix strucutre out of bounds
CyrusNajmabadi Jul 23, 2025
9288f35
Tests
CyrusNajmabadi Jul 23, 2025
7407480
Add Version.Details.props (#79539)
dkurepa Jul 23, 2025
f9fdf65
Fix issue with 'use explicit type' and nullable tuples
CyrusNajmabadi Jul 23, 2025
1280cad
Add back
CyrusNajmabadi Jul 23, 2025
a8ffa9a
Get rid of legacy test methods. (#79532)
CyrusNajmabadi Jul 23, 2025
ff90019
Merge branch 'main' into testCollapse
CyrusNajmabadi Jul 23, 2025
841a82a
Convert ValueTaskFactory methods to static extensions (#79541)
tmat Jul 23, 2025
94122f9
Update logic
CyrusNajmabadi Jul 23, 2025
6cdb427
Also downgrade System.Numerics.Vectors for VS
dibarbet Jul 23, 2025
50c2db6
Fix out of bounds when creating structure guides for types without bo…
CyrusNajmabadi Jul 23, 2025
5f51f25
Remove lots of duplication in our test harness. (#79536)
CyrusNajmabadi Jul 23, 2025
fadd60c
Fix name qualification when moving a using alias outside of a file sc…
CyrusNajmabadi Jul 23, 2025
50d2e33
Add Enum static extensions (#79546)
tmat Jul 23, 2025
6fe818a
Fix issue with 'use explicit type' and nullable tuples (#79544)
CyrusNajmabadi Jul 23, 2025
7f4300c
Fix location of 'partial' modifier when generating new partial member…
CyrusNajmabadi Jul 23, 2025
c263828
Also downgrade System.Numerics.Vectors for VS (#79548)
dibarbet Jul 23, 2025
e84ba98
Fix main build break
dibarbet Jul 23, 2025
829244a
Properly handle optional arguments when converting a local function t…
CyrusNajmabadi Jul 23, 2025
4ec123d
Fix main build break (#79554)
CyrusNajmabadi Jul 23, 2025
4675d65
Fix main build break AGAIN
dibarbet Jul 23, 2025
1a74e66
Projects to deploy (#79430)
tmat Jul 23, 2025
e67e2a4
Fix main build break AGAIN (#79559)
dibarbet Jul 24, 2025
ebd92a8
[main] Source code updates from dotnet/dotnet (#79483)
dotnet-maestro[bot] Jul 24, 2025
a6098be
[main] Source code updates from dotnet/dotnet (#79563)
dotnet-maestro[bot] Jul 24, 2025
38f9abe
Revert "Fix main build break AGAIN (#79559)"
CyrusNajmabadi Jul 24, 2025
6a5c663
Tweak build break fix
CyrusNajmabadi Jul 24, 2025
f09ae20
Tweak build break fix
CyrusNajmabadi Jul 24, 2025
d511f98
inline test strings
CyrusNajmabadi Jul 24, 2025
695749d
Add back in helpers that were removed in #79559 (#79567)
CyrusNajmabadi Jul 24, 2025
9b3e554
Cleanup test methods
CyrusNajmabadi Jul 24, 2025
c0b76d1
Fix issue where we weren't properly adding elastic trivia to newly ge…
CyrusNajmabadi Jul 24, 2025
210d31a
Fix behavior
CyrusNajmabadi Jul 24, 2025
6e73c9f
Add test
CyrusNajmabadi Jul 24, 2025
50561d7
Further simplification of common test patterns. (#79568)
CyrusNajmabadi Jul 24, 2025
80f17c4
Fix issue where we weren't properly adding elastic trivia to newly ge…
CyrusNajmabadi Jul 24, 2025
0945644
Mark SyntaxTokenParser as non-experimental (#79521)
Copilot Jul 24, 2025
a9c63d3
Merge remote-tracking branch 'upstream/main' into merge-main
333fred Jul 24, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
41 changes: 19 additions & 22 deletions azure-pipelines-pr-validation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -165,28 +165,6 @@ extends:
displayName: Setting SourceBranchName variable
condition: succeeded()

- task: Powershell@2
name: FancyBuild
displayName: Setting FancyBuild.BuildNumber
inputs:
targetType: inline
script: |
$pull_request = Invoke-RestMethod -Uri "https://api.github.com/repos/dotnet/roslyn/pulls/${{ parameters.PRNumber }}" `
-Headers @{
"Accept" = "application/vnd.github+json";
"X-GitHub-Api-Version" = "2022-11-28"
}
$buildNumberName = "$(OriginalBuildNumber) - $($pull_request.user.login) - '$($pull_request.title)'"
$buildNumberName = $buildNumberName -replace '["/:<>\|?@*]','_'
# Maximum buildnumber length is 255 chars and we are going to append to the end to ensure we have space.
if ($buildNumberName.Length -GT 253) {
$buildNumberName = $buildNumberName.Substring(0, 253)
}
# Avoid ever ending the BuildNumber with a `.` by always appending to it.
$buildNumberName += ' #'
Write-Host "##vso[task.setvariable variable=BuildNumber;isoutput=true;isreadonly=true]$buildNumberName"
Write-Host "##vso[build.updatebuildnumber]$buildNumberName"

- task: Powershell@2
displayName: Tag PR validation build
inputs:
Expand All @@ -204,6 +182,25 @@ extends:
arguments: "-sourceBranchName $(SourceBranchName) -prNumber ${{ parameters.PRNumber }} -commitSHA ${{ parameters.CommitSHA }} -enforceLatestCommit ${{ iif(parameters.EnforceLatestCommit, '1', '0') }}"
condition: succeeded()

- task: Powershell@2
name: FancyBuild
displayName: Setting FancyBuild.BuildNumber
inputs:
targetType: inline
script: |
$authorName = git log -1 --pretty=format:"%an" ${{ parameters.CommitSHA }}

$buildNumberName = "$(OriginalBuildNumber) - $($authorName) - '${{ parameters.PRNumber }}'"
$buildNumberName = $buildNumberName -replace '["/:<>\|?@*]','_'
# Maximum buildnumber length is 255 chars and we are going to append to the end to ensure we have space.
if ($buildNumberName.Length -GT 253) {
$buildNumberName = $buildNumberName.Substring(0, 253)
}
# Avoid ever ending the BuildNumber with a `.` by always appending to it.
$buildNumberName += ' #'
Write-Host "##vso[task.setvariable variable=BuildNumber;isoutput=true;isreadonly=true]$buildNumberName"
Write-Host "##vso[build.updatebuildnumber]$buildNumberName"

- powershell: Write-Host "##vso[task.setvariable variable=VisualStudio.DropName]Products/$(System.TeamProject)/$(Build.Repository.Name)/$(SourceBranchName)/$(OriginalBuildNumber)"
displayName: Setting VisualStudio.DropName variable

Expand Down
8 changes: 7 additions & 1 deletion azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -400,13 +400,19 @@ stages:
configuration: Release
- name: compilerChange
value: $[dependencies.Determine_Changes.outputs['SetPathVars_compilers.containsChange']]
# Set NUGET_PACKAGES to fix issues with package Restore when building with `-ci`.
# Workaround for https://github.com/dotnet/arcade/issues/15970
- name: NUGET_PACKAGES
value: $(Build.SourcesDirectory)\.packages
steps:
- template: eng/pipelines/checkout-windows-task.yml

- powershell: eng/build.ps1 -configuration Release -prepareMachine -ci -restore -binaryLogName Restore.binlog
displayName: Restore

- powershell: eng/build.ps1 -configuration Release -prepareMachine -ci -build -pack -publish -sign -binaryLogName Build.binlog /p:DotnetPublishUsingPipelines=true /p:ContinuousIntegrationBuildCorrectness=true
# We additionally restore during the build because the Microsoft.DotNet.Build.Tasks.Feed package only restores when we pass `-publish`. See https://github.com/dotnet/arcade/blob/37ccfd66358af6a37a0ec385ec31d1d71bdd8723/src/Microsoft.DotNet.Arcade.Sdk/tools/Tools.proj#L61-L66
# Passing `-publish` during the restore step above fails due to no items needing published.
- powershell: eng/build.ps1 -configuration Release -prepareMachine -ci -restore -build -pack -publish -sign -binaryLogName Build.binlog /p:DotnetPublishUsingPipelines=true /p:ContinuousIntegrationBuildCorrectness=true
displayName: Build

# While this task is not executed in the official build, this serves as a PR check for whether symbol exclusions
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Particularly for developers who aren't experienced with .NET Core development on
1. Install [VS Code](https://code.visualstudio.com/Download)
- After you install VS Code, install the [C# extension](https://marketplace.visualstudio.com/items?itemName=ms-dotnettools.csharp)
- Important tip: You can look up editor commands by name by hitting *Ctrl+Shift+P*, or by hitting *Ctrl+P* and typing a `>` character. This will help you get familiar with editor commands mentioned below. On a Mac, use *⌘* instead of *Ctrl*.
1. Install the [.NET 9.0 SDK](https://dotnet.microsoft.com/en-us/download/dotnet/9.0) which matches the `sdk.version` property in [global.json](../../global.json#L3)
1. Install the [.NET 10.0 SDK](https://dotnet.microsoft.com/en-us/download/dotnet/10.0) which matches the `sdk.version` property in [global.json](../../global.json#L3)
3. You can build from VS Code by running the *Run Build Task* command, then selecting an appropriate task such as *build* or *build current project* (the latter builds the containing project for the current file you're viewing in the editor).
4. You can run tests from VS Code by opening a test class in the editor, then using the *Run Tests in Context* and *Debug Tests in Context* editor commands. You may want to bind these commands to keyboard shortcuts that match their Visual Studio equivalents (**Ctrl+R, T** for *Run Tests in Context* and **Ctrl+R, Ctrl+T** for *Debug Tests in Context*).
5. You can launch a new VS Code instance with the language server from your current code by running the "launch vscode with language server" task.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ The minimal required version of .NET Framework is 4.7.2.
- Ensure C# and Visual Basic, MSBuild, and .NET Core are included in the selected individual components
- Ensure "Use previews of the .NET Core SDK" is checked in Tools -> Options -> Environment -> Preview Features
- Restart Visual Studio
1. Install the [.NET 9.0 SDK](https://dotnet.microsoft.com/en-us/download/dotnet/9.0) which matches the `sdk.version` property in [global.json](../../global.json#L3)
1. Install the [.NET 10.0 SDK](https://dotnet.microsoft.com/en-us/download/dotnet/10.0) which matches the `sdk.version` property in [global.json](../../global.json#L3)
1. [PowerShell 5.0 or newer](https://docs.microsoft.com/en-us/powershell/scripting/setup/installing-windows-powershell). If you are on Windows 10, you are fine; you'll only need to upgrade if you're on earlier versions of Windows. The download link is under the ["Upgrading existing Windows PowerShell"](https://docs.microsoft.com/en-us/powershell/scripting/install/installing-windows-powershell?view=powershell-6#upgrading-existing-windows-powershell) heading.
1. Run Restore.cmd
1. Open Roslyn.sln
Expand Down
2 changes: 1 addition & 1 deletion docs/contributing/Compiler Test Plan.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ This document provides guidance for thinking about language interactions and tes
- Compiler-recognized attributes should not have any effect in earlier LangVersions,
except a LangVersion error should be reported when functionality depending on the attribute is used
(for example, InlineArray conversion to Span).
- Generics (type arguments, variance, constraints including `class`, `struct`, `new()`, `unmanaged`, `notnull`, types and interfaces with nullability)
- Generics (type arguments, variance, constraints including `class`, `struct`, `new()`, `unmanaged`, `notnull`, `allows ref struct`, types and interfaces with nullability)
- Default and constant values
- Partial classes
- Literals
Expand Down
7 changes: 4 additions & 3 deletions eng/Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
<RoslynDiagnosticsNugetPackageVersion>3.11.0-beta1.24081.1</RoslynDiagnosticsNugetPackageVersion>
<MicrosoftCodeAnalysisNetAnalyzersVersion>8.0.0-preview.23468.1</MicrosoftCodeAnalysisNetAnalyzersVersion>
<MicrosoftCodeAnalysisTestingVersion>1.1.3-beta1.24319.1</MicrosoftCodeAnalysisTestingVersion>
<MicrosoftVisualStudioExtensibilityTestingVersion>0.1.785-beta</MicrosoftVisualStudioExtensibilityTestingVersion>
<_BasicReferenceAssembliesVersion>1.7.9</_BasicReferenceAssembliesVersion>
<MicrosoftVisualStudioExtensibilityTestingVersion>0.1.796-beta</MicrosoftVisualStudioExtensibilityTestingVersion>
<_BasicReferenceAssembliesVersion>1.8.3</_BasicReferenceAssembliesVersion>
<!-- CodeStyleAnalyzerVersion should we updated together with version of dotnet-format in dotnet-tools.json -->
<CodeStyleAnalyzerVersion>4.8.0-3.final</CodeStyleAnalyzerVersion>
<VisualStudioEditorPackagesVersion>17.13.226</VisualStudioEditorPackagesVersion>
Expand Down Expand Up @@ -273,7 +273,7 @@
<PackageVersion Include="xunit.core" Version="$(_xunitVersion)" />
<PackageVersion Include="Xunit.Combinatorial" Version="1.6.24" />
<PackageVersion Include="xunit.extensibility.core" Version="$(_xunitVersion)" />
<PackageVersion Include="xunit.runner.visualstudio" Version="3.1.1" />
<PackageVersion Include="xunit.runner.visualstudio" Version="3.1.3" />
<PackageVersion Include="xunit.runner.utility" Version="$(_xunitVersion)" />
<PackageVersion Include="xunit.abstractions" Version="2.0.3" />
<PackageVersion Include="xunit.extensibility.execution" Version="$(_xunitVersion)" />
Expand All @@ -297,6 +297,7 @@
<PackageVersion Include="Basic.Reference.Assemblies.Net461" Version="$(_BasicReferenceAssembliesVersion)" />
<PackageVersion Include="Basic.Reference.Assemblies.NetStandard13" Version="$(_BasicReferenceAssembliesVersion)" />
<PackageVersion Include="Basic.Reference.Assemblies.Net90" Version="$(_BasicReferenceAssembliesVersion)" />
<PackageVersion Include="Basic.Reference.Assemblies.Net100" Version="$(_BasicReferenceAssembliesVersion)" />
<PackageVersion Include="Microsoft.TeamFoundationServer.Client" Version="19.232.0-preview" />
<PackageVersion Include="System.Data.SqlClient" Version="$(SystemDataSqlClientVersion)" />
<!-- fix of vulnerability in 6.0.0 coming via Microsoft.TeamFoundationServer.Client -->
Expand Down
19 changes: 17 additions & 2 deletions eng/Publishing.props
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,14 @@
<!--
During PR Validation we only need to publish symbols with Arcade,
since our packages are published separately to the CoreXT feed.

Also, do not publish any symbols packages in source-only builds.
-->
<Target Name="_ResolvePublishRoslynNuGetPackages"
DependsOnTargets="BeforePublish"
BeforeTargets="PublishToAzureDevOpsArtifacts"
Condition=" '$(PreReleaseVersionLabel)' == 'pr-validation' ">
Condition=" '$(PreReleaseVersionLabel)' == 'pr-validation' or '$(DotNetBuildSourceOnly)' == 'true' ">

<ItemGroup>
<!-- Determine all NuGet packages being published -->
<_NuGetPackagesToPush Include="@(ItemsToPushToBlobFeed)"
Expand All @@ -30,13 +33,25 @@
<!-- Determine all symbol packages being published -->
<_SymbolPackagesToPush Include="@(_NuGetPackagesToPush)"
Condition="$([System.String]::Copy(%(FullPath)).EndsWith('.symbols.nupkg'))" />
<_SymbolPackagesToPush Include="@(_NuGetPackagesToPush)"
Condition="$([System.String]::Copy(%(FullPath)).Contains('.Symbols.'))" />
</ItemGroup>

<ItemGroup Condition=" '$(PreReleaseVersionLabel)' == 'pr-validation' ">
<!-- Remove all NuGet packages from being published -->
<ItemsToPushToBlobFeed Remove="@(_NuGetPackagesToPush)" />
</ItemGroup>

<ItemGroup Condition=" '$(DotNetBuildSourceOnly)' == 'true' ">
<!-- Remove all symbols packages from being published -->
<ItemsToPushToBlobFeed Remove="@(_SymbolPackagesToPush)" />
</ItemGroup>

<!-- Include symbol packages for publishing -->
<ItemGroup Condition=" '$(PreReleaseVersionLabel)' == 'pr-validation' and '$(DotNetBuildSourceOnly)' != 'true' ">
<!-- Include symbol packages for publishing-->
<ItemsToPushToBlobFeed Include="@(_SymbolPackagesToPush)" />
</ItemGroup>

</Target>

</Project>
1 change: 1 addition & 0 deletions eng/Version.Details.props
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<!-- will get filled in the next backflow -->
20 changes: 10 additions & 10 deletions eng/Version.Details.xml
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
<?xml version="1.0" encoding="utf-8"?>
<Dependencies>
<Source Uri="https://github.com/dotnet/dotnet" Mapping="roslyn" Sha="f451e5d3036a4f140a989e0a7f3f1ae432420e71" BarId="274568" />
<Source Uri="https://github.com/dotnet/dotnet" Mapping="roslyn" Sha="c0e325f90fb79db0da6be5128dc292f2aabb264f" BarId="276450" />
<ProductDependencies>
<!-- RoslynAnalyzers reference older builds of Roslyn and this is necessary for SourceBuild. -->
<Dependency Name="Microsoft.CodeAnalysis" Version="3.11.0">
<Uri>https://github.com/dotnet/roslyn</Uri>
<Sha>ae1fff344d46976624e68ae17164e0607ab68b10</Sha>
</Dependency>
<Dependency Name="System.CommandLine" Version="2.0.0-beta5.25210.1">
<Uri>https://github.com/dotnet/command-line-api</Uri>
<Sha>e9b0511d7f1128e2bc3be7a658a2a4ea977e602d</Sha>
<Dependency Name="System.CommandLine" Version="2.0.0-beta7.25373.104">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>c0e325f90fb79db0da6be5128dc292f2aabb264f</Sha>
</Dependency>
<!-- Necessary for source-build. This allows the live version of the package to be used by source-build. -->
<Dependency Name="Microsoft.Bcl.AsyncInterfaces" Version="9.0.0">
Expand Down Expand Up @@ -110,13 +110,13 @@
</Dependency>
</ProductDependencies>
<ToolsetDependencies>
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="10.0.0-beta.25259.2">
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="10.0.0-beta.25367.5">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>80c4e4d26cb85c86f7e1be77d2d9eceeef0f3493</Sha>
<Sha>d777c20040bdc2e52b372fa98dcb84141ed692d3</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.XliffTasks" Version="10.0.0-beta.25259.2">
<Dependency Name="Microsoft.DotNet.XliffTasks" Version="10.0.0-beta.25367.5">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>80c4e4d26cb85c86f7e1be77d2d9eceeef0f3493</Sha>
<Sha>d777c20040bdc2e52b372fa98dcb84141ed692d3</Sha>
</Dependency>
<Dependency Name="Microsoft.DiaSymReader" Version="2.0.0">
<Uri>https://github.com/dotnet/symreader</Uri>
Expand All @@ -126,9 +126,9 @@
<Uri>https://github.com/dotnet/roslyn</Uri>
<Sha>5d10d428050c0d6afef30a072c4ae68776621877</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Helix.Sdk" Version="10.0.0-beta.25259.2">
<Dependency Name="Microsoft.DotNet.Helix.Sdk" Version="10.0.0-beta.25367.5">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>80c4e4d26cb85c86f7e1be77d2d9eceeef0f3493</Sha>
<Sha>d777c20040bdc2e52b372fa98dcb84141ed692d3</Sha>
</Dependency>
<Dependency Name="Microsoft.CodeAnalysis.NetAnalyzers" Version="8.0.0-preview.23468.1">
<Uri>https://github.com/dotnet/roslyn-analyzers</Uri>
Expand Down
14 changes: 7 additions & 7 deletions eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -32,23 +32,23 @@
</PropertyGroup>
<PropertyGroup Condition="'$(DotNetBuildSourceOnly)' != 'true'">
<MicrosoftIORedistVersion>6.0.1</MicrosoftIORedistVersion>
<SystemBuffersVersion>4.5.1</SystemBuffersVersion>
<SystemBuffersVersion>4.6.0</SystemBuffersVersion>
<!--
Microsoft.TeamFoundationServer.Client is referencing System.Data.SqlClient causing CG alert
When it updates its referenced System.Data.SqlClient version this should be removed
-->
<SystemDataSqlClientVersion>4.8.6</SystemDataSqlClientVersion>
<SystemMemoryVersion>4.5.5</SystemMemoryVersion>
<SystemNumericsVectorsVersion>4.5.0</SystemNumericsVectorsVersion>
<SystemRuntimeCompilerServicesUnsafeVersion>6.0.0</SystemRuntimeCompilerServicesUnsafeVersion>
<SystemThreadingTasksExtensionsVersion>4.5.4</SystemThreadingTasksExtensionsVersion>
<SystemMemoryVersion>4.6.0</SystemMemoryVersion>
<SystemNumericsVectorsVersion>4.6.0</SystemNumericsVectorsVersion>
<SystemRuntimeCompilerServicesUnsafeVersion>6.1.0</SystemRuntimeCompilerServicesUnsafeVersion>
<SystemThreadingTasksExtensionsVersion>4.6.0</SystemThreadingTasksExtensionsVersion>
<SystemValueTupleVersion>4.5.0</SystemValueTupleVersion>
</PropertyGroup>
<!--
Versions managed by Arcade (see Versions.Details.xml)
-->
<PropertyGroup>
<SystemCommandLineVersion>2.0.0-beta5.25210.1</SystemCommandLineVersion>
<SystemCommandLineVersion>2.0.0-beta7.25373.104</SystemCommandLineVersion>
<SystemCompositionVersion>9.0.0</SystemCompositionVersion>
<SystemConfigurationConfigurationManagerVersion>9.0.0</SystemConfigurationConfigurationManagerVersion>
<SystemDiagnosticsEventLogVersion>9.0.0</SystemDiagnosticsEventLogVersion>
Expand Down Expand Up @@ -147,7 +147,7 @@
<UsingToolXUnit>false</UsingToolXUnit>
<UseVSTestRunner>true</UseVSTestRunner>
<!-- Prohibit the usage of .NET Standard 1.x dependencies. -->
<FlagNetStandard1XDependencies Condition="'$(DotNetBuildSourceOnly)' == 'true' and '$(DotNetBuildOrchestrator)' == 'true'">true</FlagNetStandard1XDependencies>
<FlagNetStandard1XDependencies Condition="'$(DotNetBuildSourceOnly)' == 'true' and '$(DotNetBuildFromVMR)' == 'true'">true</FlagNetStandard1XDependencies>
</PropertyGroup>
<PropertyGroup>
<!--
Expand Down
4 changes: 4 additions & 0 deletions eng/common/core-templates/steps/install-microbuild.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ steps:
${{ if and(eq(parameters.enableMicrobuildForMacAndLinux, 'true'), ne(variables['Agent.Os'], 'Windows_NT')) }}:
azureSubscription: 'MicroBuild Signing Task (DevDiv)'
useEsrpCli: true
${{ elseif eq(variables['System.TeamProject'], 'DevDiv') }}:
ConnectedPMEServiceName: 6cc74545-d7b9-4050-9dfa-ebefcc8961ea
${{ else }}:
ConnectedPMEServiceName: 248d384a-b39b-46e3-8ad5-c2c210d5e7ca
env:
TeamName: $(_TeamName)
MicroBuildOutputFolderOverride: ${{ parameters.microBuildOutputFolder }}
Expand Down
6 changes: 0 additions & 6 deletions eng/common/core-templates/steps/source-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,6 @@ steps:
targetRidArgs='/p:TargetRid=${{ parameters.platform.targetRID }}'
fi

baseRidArgs=
if [ '${{ parameters.platform.baseRID }}' != '' ]; then
baseRidArgs='/p:BaseRid=${{ parameters.platform.baseRID }}'
fi

portableBuildArgs=
if [ '${{ parameters.platform.portableBuild }}' != '' ]; then
portableBuildArgs='/p:PortableBuild=${{ parameters.platform.portableBuild }}'
Expand All @@ -55,7 +50,6 @@ steps:
${{ parameters.platform.buildArguments }} \
$internalRuntimeDownloadArgs \
$targetRidArgs \
$baseRidArgs \
$portableBuildArgs \
displayName: Build

Expand Down
7 changes: 7 additions & 0 deletions eng/common/dotnet.cmd
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
@echo off

:: This script is used to install the .NET SDK.
:: It will also invoke the SDK with any provided arguments.

powershell -ExecutionPolicy ByPass -NoProfile -command "& """%~dp0dotnet.ps1""" %*"
exit /b %ErrorLevel%
11 changes: 11 additions & 0 deletions eng/common/dotnet.ps1
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# This script is used to install the .NET SDK.
# It will also invoke the SDK with any provided arguments.

. $PSScriptRoot\tools.ps1
$dotnetRoot = InitializeDotNetCli -install:$true

# Invoke acquired SDK with args if they are provided
if ($args.count -gt 0) {
$env:DOTNET_NOLOGO=1
& "$dotnetRoot\dotnet.exe" $args
}
Loading