Adjust visibility of extension marker method in metadata once more #79617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlekseyTs
added
Area-Compilers
Feature - Extension Everything
jjonescz
reviewed
Jul 25, 2025
|
|
||
| foreach (var extension in GetCorrespondingMarkerType((SourceNamedTypeSymbol)marker.ContainingType).UnderlyingExtensions) | ||
| { | ||
| foreach (var symbol in extension.GetMembers()) |
Member
There was a problem hiding this comment.
Why are we using members now to infer the visibility? #Resolved
Contributor
Author
There was a problem hiding this comment.
Why are we using members now to infer the visibility?
We discussed this in our working group and decided that doing this will be better. For example, empty extensions will not have impact on public surface. If all members are internal, there will be no impact on public surface even if extended type is public, etc.
jjonescz
approved these changes
Jul 28, 2025
This was referenced Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speclet change dotnet/csharplang#9550
Relates to test plan #76130