Extensions: address follow-ups for new metadata design #79674
Conversation
jcouv
added
Area-Compilers
Feature - Extension Everything
jcouv
force-pushed
the
extensions-prototype
branch
2 times, most recently
from
f3755e9 to
9deb8e6
Compare
jcouv
force-pushed
the
extensions-prototype
branch
from
9deb8e6 to
9b0d740
Compare
| { | ||
| case SymbolKind.NamedType: | ||
| if (!((NamedTypeSymbol)member).IsExtension) // PROTOTYPE: Figure out what to do about extensions, if anything | ||
| if (!((NamedTypeSymbol)member).IsExtension) // Tracked by https://github.com/dotnet/roslyn/issues/78963 : Figure out what to do about extensions, if anything |
There was a problem hiding this comment.
📝 added tracking bullet to the issue ("do we need special handling in GetSymbolToLocationMap (scenario related to winobj files)")
It looks like this test and the tests below do not test this fact. They test that things are merged, but do not actually test if the names are in metadata for the grouping type. So, if that was the intent of the test, it was not achieved. In order to achieve it, we could get to the PENamedTypeSymbol representing the grouping type in metadata. Our implementation gets grouping name from that symbol, for example. #Closed Refers to: src/Compilers/CSharp/Test/Emit3/Semantics/ExtensionTests2.cs:25506 in 9b0d740. [](commit_id = 9b0d740, deletion_comment = False) |
In addressing this, I realized the event is malformed. The accessors in In reply to: 3142036745 Refers to: src/Compilers/CSharp/Test/Emit3/Semantics/ExtensionTests2.cs:4490 in 9b0d740. [](commit_id = 9b0d740, deletion_comment = False) |
Adjusted comment In reply to: 3145111607 Refers to: src/Compilers/CSharp/Test/Emit3/Semantics/ExtensionTests2.cs:25506 in 9b0d740. [](commit_id = 9b0d740, deletion_comment = False) |
The response sounds like the attribute has been added? but I do not see any changes like that. In reply to: 3145147928 Refers to: src/Compilers/CSharp/Test/Emit3/Semantics/ExtensionTests2.cs:4490 in 9b0d740. [](commit_id = 9b0d740, deletion_comment = False) |
Actually, I see a new test added with the attributes In reply to: 3146130980 Refers to: src/Compilers/CSharp/Test/Emit3/Semantics/ExtensionTests2.cs:4490 in 9b0d740. [](commit_id = 9b0d740, deletion_comment = False) |
3 participants
Erase attribute in PE
Disallow attribute in source
Verify round-tripping on extension block
Re-enable skipped tests
Addresses some of the follow-up issues tracked by #78963
Relates to test plan #76130