Skip to content

Conversation

@AlekseyTs
Copy link
Contributor

@AlekseyTs AlekseyTs commented Aug 4, 2025

Relates to test plan #76130

@AlekseyTs AlekseyTs requested review from jcouv and jjonescz August 4, 2025 04:10
@AlekseyTs AlekseyTs requested a review from a team as a code owner August 4, 2025 04:10
@AlekseyTs AlekseyTs added Area-Compilers Feature - Extension Everything The extension everything feature labels Aug 4, 2025
@AlekseyTs
Copy link
Contributor Author

@jcouv, @jjonescz, @dotnet/roslyn-compiler Please review a small change

@jcouv jcouv self-assigned this Aug 4, 2025
@AlekseyTs
Copy link
Contributor Author

@jcouv, @jjonescz, @dotnet/roslyn-compiler For a second review. A small change

Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (commit 1)

{
// Extension block symbols declared in a class are grouped by their corresponding grouping type metadata name (top level key),
// then grouped by their corresponding extension marker type metadata name (the secondary key used by MultiDictionary).
// <see cref="SourceNamedTypeSymbol"/>s are the extension blocks.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we're no longer in doc comment

@AlekseyTs AlekseyTs enabled auto-merge (squash) August 8, 2025 00:30
@AlekseyTs AlekseyTs merged commit 70384b5 into dotnet:features/extensions Aug 8, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers Feature - Extension Everything The extension everything feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants