Reduce allocations in DeclarationComputer #79782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a draft until I get back numbers from a speedometer run. CSharpDeclarationComputer.ComputeDeclarations shows up as 1.0% of Roslyn OOP allocations during a completion scenario in the RazorEditingTests.CompletionInCohosting speedometer test. The majority of the allocations under this method appear to be linq related, so switching to the model where we use a pooled collection to collect the items rather than linq enumerables.
…e more obvious after looking at a test run with changes from the first commit
ToddGrun
changed the title
ToddGrun
changed the title
Contributor
Author
|
@dotnet/roslyn-compiler -- ptal |
jcouv
reviewed
Aug 25, 2025
Member
|
@dotnet/roslyn-compiler for second review. Thanks |
| var codeBlocks = ImmutableArray<SyntaxNode>.Empty; | ||
| if (executableCodeBlocks != null) | ||
| { | ||
| executableCodeBlocks.RemoveAll(c => c == null); |
Member
There was a problem hiding this comment.
might be nicer to use AddIfNotNull at the callsites, so taht there can't be nulls in here in the first place. #Resolved
Contributor
Author
There was a problem hiding this comment.
Looked into it, and there are quite a few callers, so I don't think I want to mess with that in this PR.
CyrusNajmabadi
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSharpDeclarationComputer.ComputeDeclarations shows up as 1.0% of Roslyn OOP allocations during a completion scenario in the RazorEditingTests.CompletionInCohosting speedometer test. The majority of the allocations under this method appear to be linq related, so switching to the model where we use a pooled collection to collect the items rather than linq enumerables.
Test insertion: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/659161
*** Before this change ***
*** With this change ***
