Skip to content

Simplify code that was always using a constant. #79801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 6, 2025
Merged

Simplify code that was always using a constant. #79801

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fdd0ad9
Simplify code
CyrusNajmabadi Aug 6, 2025
8bb67be
remove comment
CyrusNajmabadi Aug 6, 2025
4a911a9
remove comment
CyrusNajmabadi Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions ...lStudio/Core/Impl/SolutionExplorer/DiagnosticItem/BaseDiagnosticAndGeneratorItemSource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,7 @@ private async ValueTask ProcessQueueAsync(CancellationToken cancellationToken)
return;
}

// Currently only project analyzers show in Solution Explorer, so isHostAnalyzer is always false.
var newDiagnosticItems = GenerateDiagnosticItems(project, analyzerReference, isHostAnalyzer: false);
var newDiagnosticItems = GenerateDiagnosticItems(project, analyzerReference);
var newSourceGeneratorItems = await GenerateSourceGeneratorItemsAsync(
project, analyzerReference).ConfigureAwait(false);

Expand All @@ -143,8 +142,7 @@ private async ValueTask ProcessQueueAsync(CancellationToken cancellationToken)

ImmutableArray<BaseItem> GenerateDiagnosticItems(
Project project,
AnalyzerReference analyzerReference,
bool isHostAnalyzer)
AnalyzerReference analyzerReference)
{
var generalDiagnosticOption = project.CompilationOptions!.GeneralDiagnosticOption;
var specificDiagnosticOptions = project.CompilationOptions!.SpecificDiagnosticOptions;
Expand All @@ -160,7 +158,7 @@ ImmutableArray<BaseItem> GenerateDiagnosticItems(
var selectedDiagnostic = g.OrderBy(d => d, s_comparer).First();
var effectiveSeverity = selectedDiagnostic.GetEffectiveSeverity(
project.CompilationOptions!,
isHostAnalyzer ? analyzerConfigOptions?.ConfigOptionsWithFallback : analyzerConfigOptions?.ConfigOptionsWithoutFallback,
analyzerConfigOptions?.ConfigOptionsWithoutFallback,
analyzerConfigOptions?.TreeOptions);
return (BaseItem)new DiagnosticItem(project.Id, analyzerReference, selectedDiagnostic, effectiveSeverity, CommandHandler);
});
Expand Down
Loading