Update new IDiagnosticAnalyzerService methods to be async. #79809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| editorConfigFileName: FileName); | ||
|
|
||
| UpdateOptions(options, solution, projects); | ||
| // TODO(cyrusn): Do we need to track this work in some way? |
Member
There was a problem hiding this comment.
Is there also a risk of racing if multiple things are happening at once now too? Are we better off just making this a JTF.Run() and keeping it synchronous rather than introducing regressions here which we aren't going to want to investigate?
jasonmalinowski
approved these changes
Aug 9, 2025
Member
jasonmalinowski
left a comment
jasonmalinowski
left a comment
There was a problem hiding this comment.
Looks fine other than that TODO about 'do we need to track this work'? Should we just keep that a synchronous JTF.Run() and come back to that later? Yes that might UI delay but we can invest in making that better later if needed, as opposed to introducing bugs now...
src/VisualStudio/Core/Def/TaskList/ExternalErrorDiagnosticUpdateSource.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/Core/Def/TaskList/ExternalErrorDiagnosticUpdateSource.cs
Outdated
Show resolved
Hide resolved
This was referenced Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #79808.
Doing this allows them to be remotable to our OOP service.