Reduce allocations from calling ITypeSymbol.AllInterfaces #79817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method accounts for 2.0% of allocations during completion in the CompletionInCohosting Razor speedometer test. Razor uses this method from a couple disparate locations (mostly around detecting taghelpers and components). I've verified locally that about 2/3 of these allocations can be removed by having the InterfaceInfo cache the public symbol array information too.
ToddGrun
changed the title
Contributor
Author
|
@dotnet/roslyn-compiler -- ptal |
333fred
approved these changes
Aug 19, 2025
AlekseyTs
reviewed
Aug 19, 2025
AlekseyTs
reviewed
Aug 19, 2025
Contributor
|
Done with review pass (commit 1) |
333fred
approved these changes
Aug 26, 2025
Member
333fred
left a comment
333fred
left a comment
There was a problem hiding this comment.
@dotnet/roslyn-compiler for a second review.
CyrusNajmabadi
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method usually accounts for ~1% of allocations in the Roslyn CodeAnalysis process during completion scenarios in the CompletionInCohosting Razor speedometer test.
Razor uses this method from a couple disparate locations (mostly around detecting taghelpers and components). This PR changes the cached InterfaceInfo to keep an IA for the public symbols in addition to the internal symbols, as razor requests the public symbols multiple times.
Test insertion: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/659529
The speedometer test seems to have a high amount of variance in allocations, but before this change usually sat around 1% of allocations in the profiles under this callstack. After this change, that number sits more around 0.6%.
*** Before ***
*** After ***
and