Skip to content

Fix failing test case BindingAsyncTasklikeMoreTests.Dynamic on Mono #79878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 19, 2025
Merged

Fix failing test case BindingAsyncTasklikeMoreTests.Dynamic on Mono #79878

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1374610
Fix failing test case Microsoft.CodeAnalysis.CSharp.UnitTests.Semanti…
Venkad000 Aug 12, 2025
6aa33c6
Put the condition down in one parameter
Venkad000 Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions src/Compilers/CSharp/Test/Semantic/Semantics/BindingAsyncTasklikeMoreTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,9 +647,23 @@ public void AwaitUnsafeOnCompleted<TAwaiter, TStateMachine>(ref TAwaiter awaiter
namespace System.Runtime.CompilerServices { class AsyncMethodBuilderAttribute : System.Attribute { public AsyncMethodBuilderAttribute(System.Type t) { } } }
";
var compilation = CreateCompilationWithMscorlib461(source, references: new MetadataReference[] { CSharpRef, SystemCoreRef });
var verifier = CompileAndVerify(
compilation,
expectedSignatures: new[]
var expectedSignatures = ExecutionConditionUtil.IsMonoCore
? new[]
{
Signature(
"C+<>c__DisplayClass2_0",
"<M>b__0",
".method [System.Runtime.CompilerServices.AsyncStateMachineAttribute(C+<>c__DisplayClass2_0+<<M>b__0>d)] assembly hidebysig instance [System.Runtime.CompilerServices.DynamicAttribute(System.Boolean[])] MyTask`1[System.Object] <M>b__0() cil managed"),
Signature(
"C+<>c__DisplayClass2_0",
"<M>b__1",
".method [System.Runtime.CompilerServices.AsyncStateMachineAttribute(C+<>c__DisplayClass2_0+<<M>b__1>d)] assembly hidebysig instance [System.Runtime.CompilerServices.DynamicAttribute(System.Boolean[])] MyTask`1[System.Object[]] <M>b__1() cil managed"),
Signature(
"C+<>c__DisplayClass2_0",
"<M>b__2",
".method [System.Runtime.CompilerServices.AsyncStateMachineAttribute(C+<>c__DisplayClass2_0+<<M>b__2>d)] assembly hidebysig instance [System.Runtime.CompilerServices.DynamicAttribute(System.Boolean[])] MyTask`1[System.Object] <M>b__2() cil managed"),
}
: new[]
{
Signature(
"C+<>c__DisplayClass2_0",
Expand All @@ -663,7 +677,12 @@ namespace System.Runtime.CompilerServices { class AsyncMethodBuilderAttribute :
"C+<>c__DisplayClass2_0",
"<M>b__2",
".method [System.Runtime.CompilerServices.AsyncStateMachineAttribute(C+<>c__DisplayClass2_0+<<M>b__2>d)] assembly hidebysig instance [System.Runtime.CompilerServices.DynamicAttribute(System.Collections.ObjectModel.ReadOnlyCollection`1[System.Reflection.CustomAttributeTypedArgument])] MyTask`1[System.Object] <M>b__2() cil managed"),
});
};

var verifier = CompileAndVerify(
compilation,
expectedSignatures: expectedSignatures);

verifier.VerifyDiagnostics();
}

Expand Down