Visit deconstruction receiver in ref safety analysis #79957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
333fred
reviewed
Aug 19, 2025
Member
There was a problem hiding this comment.
Other than the assert, what effect does the missed visit have? Are there ref safety issues we're missing reporting?
Member
Author
There was a problem hiding this comment.
No. At least now, but the assert is there for a reason - we might forget to visit some nodes that could contribute to ref analysis although that's probably unlikely in this case, hence I would be fine with just tracking the visit in DEBUG instead of doing an actual visit if that's what you are getting at.
333fred
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deconstruction expression has
left(the tuple) andright(the expression) sides. But it also carries an invocation info which is of the formleftPlaceholder.Deconstruct(...). Except the receiver (leftPlaceholder) can also be wrapped in a first-class-span conversion (or whatever else can binding of the call do). The problem was that by default, our visitors only visitleftandright. ButRefSafetyAnalysisthen analyzes the invocation and would fail in aDebug.Assertbecause the receiver wasn't visited.Fixes #78682.