Remote diagnostic service call early to OOP #79986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Aug 20, 2025
| using var _ = PooledDictionary<string, DiagnosticAnalyzer>.GetInstance(out var analyzerMap); | ||
| foreach (var analyzer in allProjectAnalyzers) | ||
| { | ||
| // In the case of multiple analyzers with the same ID, we keep the last one. |
Member
Author
There was a problem hiding this comment.
this matches logic we have elsewhere for having a host talk to OOP. I tried extracing it. but it's convoluted. will do in followup.
CyrusNajmabadi
force-pushed
the
diagOop
branch
from
93db799 to
c4b506b
Compare
AbhitejJohn
approved these changes
Aug 20, 2025
CyrusNajmabadi
closed this pull request by merging all changes
into
dotnet:main
in
4610f5a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #79985