Disable oop processing for some diagnostics calls #80048
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR this change went in with seems to have a high regression. This means one of two things (at least):
This PR at least tests if '1' is the issue. If so, we can just disable the oop call and unblock things. If this doesn't address the problem, then something deeper is in effect and we'llhave to revert #79991 entirely. That's going to be a painful change (due to subsequent prs going on), so it would be nice to avoid.
Build: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=12269021&view=results
PR: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/665108