Don't count empty script extensions as potential script files #80068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
changed the title
davidwengier
added a commit
to dotnet/razor
that referenced
this pull request
Aug 28, 2025
davidwengier
commented
Aug 28, 2025
src/Features/Core/Portable/Workspace/MiscellaneousFileUtilities.cs
Outdated
Show resolved
Hide resolved
dibarbet
approved these changes
Aug 28, 2025
This was referenced Sep 8, 2025
Member
|
I am wondering if this change also fixes this bug: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2548062 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of fixing dotnet/vscode-csharp#8595 along with dotnet/razor#12155
Razor, Xaml and TypeScript set
ScriptExtensionto an empty string, because there is no scripting support. Weird uris from the left side of a diff end up getting a file extension that is an empty string, and hence errors abound.