Do not make assumptions about content of erroneous BoundCall node based on value of InvokedAsExtensionMethod property #80256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed on value of InvokedAsExtensionMethod property Related to dotnet#78433.
AlekseyTs
added
Area-Compilers
Feature - Extension Everything
333fred
reviewed
Sep 12, 2025
Member
333fred
left a comment
333fred
left a comment
There was a problem hiding this comment.
Just a couple of minor comments.
333fred
approved these changes
Sep 12, 2025
Contributor
Author
jjonescz
reviewed
Sep 16, 2025
| // y.MemberwiseClone(); // warning2 | ||
| Diagnostic(ErrorCode.WRN_NullableValueTypeMayBeNull, "y").WithLocation(15, 9), | ||
| // (15,11): error CS1540: Cannot access protected member 'object.MemberwiseClone()' via a qualifier of type 'int?'; the qualifier must be of type 'Program' (or derived from it) | ||
| // y.MemberwiseClone(); // warning2 |
Member
There was a problem hiding this comment.
Consider adjusting the // warning2 comment (there is no warning anymore, just an error)
|
|
||
| void visitArguments(BoundCall node, ref readonly MethodInvocationInfo methodInvocationInfo) | ||
| { | ||
| if (node.IsErroneousNode) |
Member
There was a problem hiding this comment.
Why have you introduced these local functions (visitReceiver and visitArguments)? Couldn't the if (node.IsErroneousNode)s be added to the existing instance methods? #Resolved
Contributor
Author
There was a problem hiding this comment.
Why have you introduced these local functions
Because my intent is to adjust behavior of VisitCall method. I have no intent to affect any other existing or future callers of the other methods.
Contributor
Author
jjonescz
approved these changes
Sep 16, 2025
This was referenced Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #78433.